Skip to content

refactor: rename PodLocator to EndpointCandidates#2548

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
cyclinder:pod2endpoint
Apr 3, 2026
Merged

refactor: rename PodLocator to EndpointCandidates#2548
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
cyclinder:pod2endpoint

Conversation

@cyclinder
Copy link
Copy Markdown
Contributor

@cyclinder cyclinder commented Mar 11, 2026 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Rename the PodLocator interface and all related types to EndpointCandidates to better reflect that these components resolve candidate endpoints rather than just pods. Update variable names, comments, and documentation accordingly. This is a pure refactoring with no functional changes.

Which issue(s) this PR fixes:

Fixes #1969

Does this PR introduce a user-facing change?:

NONE

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 11, 2026 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit e290eee
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/69cf237097a67b0008b7b6b4
😎 Deploy Preview https://deploy-preview-2548--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2026
@ahg-g
Copy link
Copy Markdown
Contributor

ahg-g commented Mar 14, 2026

/assign @LukeAVanDrie

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2026
@cyclinder cyclinder force-pushed the pod2endpoint branch 2 times, most recently from 5d6fd76 to 037beb7 Compare March 18, 2026 10:17
@cyclinder
Copy link
Copy Markdown
Contributor Author

cyclinder commented Mar 18, 2026

@LukeAVanDrie Hi, Can you take a look?

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2026
@cyclinder cyclinder force-pushed the pod2endpoint branch 2 times, most recently from 93d6fca to bc196de Compare March 19, 2026 03:11
@LukeAVanDrie
Copy link
Copy Markdown
Contributor

LukeAVanDrie commented Mar 23, 2026

@cyclinder Sorry I missed this. Taking a look this morning

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2026
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2026
@cyclinder
Copy link
Copy Markdown
Contributor Author

cyclinder commented Mar 31, 2026

Hi @LukeAVanDrie, Do you have time to look at this?

@LukeAVanDrie
Copy link
Copy Markdown
Contributor

LukeAVanDrie commented Mar 31, 2026

Hi @LukeAVanDrie, Do you have time to look at this?

Yes, will take a look tomorrow morning. Sorry I missed this!

@cyclinder cyclinder force-pushed the pod2endpoint branch 2 times, most recently from 2129043 to 8a55b61 Compare March 31, 2026 10:34
@LukeAVanDrie
Copy link
Copy Markdown
Contributor

LukeAVanDrie commented Mar 31, 2026

/approve
/lgtm

This looks great, thanks (though your commit history looks a bit strange; might need a rebase)!

As a separate effort, we can work on migrating other occurrences of "Pod" terminology to "Endpoint", but this PR handles every instance for the PodLocator.

Also, since we've renamed PodLocator to EndpointCandidates, should we also rename locator.go to candidates.go for consistency?

Passing to @ahg-g for the final stamp

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2026
@cyclinder
Copy link
Copy Markdown
Contributor Author

cyclinder commented Apr 1, 2026

@LukeAVanDrie Thanks for your review.

Also, since we've renamed PodLocator to EndpointCandidates, should we also rename locator.go to candidates.go for consistency?

Yeah, it makes sense. updated now.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2026
@cyclinder
Copy link
Copy Markdown
Contributor Author

cyclinder commented Apr 1, 2026

This looks great, thanks (though your commit history looks a bit strange; might need a rebase)!

Nice patch, Maybe there was an issue with the previous rebase. fixed now.

@ahg-g
Copy link
Copy Markdown
Contributor

ahg-g commented Apr 2, 2026

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, cyclinder, LukeAVanDrie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 2, 2026
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 3, 2026
@cyclinder
refactor: rename PodLocator to EndpointCandidates
e290eee 
Rename PodLocator interface and related types to EndpointCandidates to better reflect that the component resolves endpoint candidates rather than pods specifically. Update all implementations, mocks, tests, and documentation accordingly.

Signed-off-by: Cyclinder Kuo <qifeng.guo@daocloud.io>
@ahg-g
Copy link
Copy Markdown
Contributor

ahg-g commented Apr 3, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2026
@k8s-ci-robot k8s-ci-robot merged commit faee462 into kubernetes-sigs:main Apr 3, 2026
11 checks passed
gyliu513 pushed a commit to gyliu513/gateway-api-inference-extension that referenced this pull request Apr 3, 2026
@cyclinder @gyliu513
refactor: rename PodLocator to EndpointCandidates (kubernetes-sigs#2548)
483ff2d 
Rename PodLocator interface and related types to EndpointCandidates to better reflect that the component resolves endpoint candidates rather than pods specifically. Update all implementations, mocks, tests, and documentation accordingly.

Signed-off-by: Cyclinder Kuo <qifeng.guo@daocloud.io>
elevran pushed a commit to llm-d/llm-d-inference-scheduler that referenced this pull request Apr 23, 2026
@cyclinder
refactor: rename PodLocator to EndpointCandidates (kubernetes-sigs/ga…
c7ef89e 
…teway-api-inference-extension#2548)

Rename PodLocator interface and related types to EndpointCandidates to better reflect that the component resolves endpoint candidates rather than pods specifically. Update all implementations, mocks, tests, and documentation accordingly.

Signed-off-by: Cyclinder Kuo <qifeng.guo@daocloud.io>
elevran pushed a commit to llm-d/llm-d-inference-scheduler that referenced this pull request May 3, 2026
@cyclinder
refactor: rename PodLocator to EndpointCandidates (kubernetes-sigs/ga…
7650610 
…teway-api-inference-extension#2548)

Rename PodLocator interface and related types to EndpointCandidates to better reflect that the component resolves endpoint candidates rather than pods specifically. Update all implementations, mocks, tests, and documentation accordingly.

Signed-off-by: Cyclinder Kuo <qifeng.guo@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahg-g ahg-g Awaiting requested review from ahg-g

@nirrozenbaum nirrozenbaum Awaiting requested review from nirrozenbaum

Assignees

@ahg-g ahg-g

@LukeAVanDrie LukeAVanDrie

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cleanup: Rename PodLocator to use Endpoint, not Pod, semantics.

4 participants

@cyclinder @ahg-g @LukeAVanDrie @k8s-ci-robot