Add deprecation notice on metrics port in runner and datastore#1886
Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom Nov 24, 2025
Merged
Conversation
k8s-ci-robot
added
the
kind/deprecation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
size/M
k8s-ci-robot
added
the
needs-rebase
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
elevran
force-pushed
the
deprecate_inference_server_metrics_port_cli
branch
from
3bb2092 to
0328e4a
Compare
k8s-ci-robot
added
size/S
Contributor
k8s-ci-robot
added
the
lgtm
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, elevran The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
janghyukjin
added a commit
to janghyukjin/gateway-api-inference-extension
that referenced
this pull request
Apr 2, 2026
Allow configuring a separate port for scraping model server metrics via EndpointPickerConfig plugin parameters. This addresses the gap left by the deprecation of --model-server-metrics-port (PR kubernetes-sigs#1886, kubernetes-sigs#2441) which had no replacement for the port configuration. When metricsPort is set in the metrics-data-source plugin parameters, it overrides the inference port encoded in the endpoint's MetricsHost. This enables deployments where model servers expose metrics on a separate port (e.g., vLLM with --metrics-port) from inference traffic, which is required in Istio mTLS STRICT environments. Related: kubernetes-sigs#1396, kubernetes-sigs#1556
elevran
added a commit
to llm-d/llm-d-inference-scheduler
that referenced
this pull request
Apr 23, 2026
…netes-sigs/gateway-api-inference-extension#1886) * add deprecation notice on metrics port in runner and datastore Signed-off-by: Etai Lev Ran <elevran@gmail.com> * simplify deprecated flags function Signed-off-by: Etai Lev Ran <elevran@gmail.com> --------- Signed-off-by: Etai Lev Ran <elevran@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind deprecation
What this PR does / why we need it:
Defining a metric port via CLI conflicts with use of multiport inference pool and/or changes to inference-pool at runtime (see #1396 and #1398).
Which issue(s) this PR fixes:
Fixes #1398
Fixes #1396
Does this PR introduce a user-facing change?: