Skip to content

Support changing InferencePool port at runtime? #1398

@elevran

Description

@elevran

Currently we allow setting the metrics fetching client Port only once:

  • initially set to the command line value (in runner.go)
  • if not specified (i.e., it is zero), it is overridden by the pool.Spec.Ports[0].Number (see here)

This means that changes in the InferencePool port specification are not supported. However, changing the Selector is supported.
It is not clear (to me) if this is intentional and desirable behavior or a bug.
If we do allow changing the port based on the Pool.Spec, we should define how it should interact with the command line value.

Side note: #1396... Would be good to understand the use case of setting the metrics port from the command line and not via the Spec.

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions