-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Remove unused Semaphore_key and mutex_name fields #12401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Remove unused Semaphore_key and mutex_name fields #12401
Conversation
|
Hi @sduvvuri1603. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
113015d to
67a1721
Compare
2316005 to
c32d84f
Compare
|
/ok-to-test |
c32d84f to
feedbf7
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e6f4751 to
abd8b2d
Compare
abd8b2d to
96a5982
Compare
Manual verificationEnvironment prep:
Baseline (before removing
After removal and rebuilt components:
Both runs use the same pipeline definition (identical workspace configuration); the only difference is the backend binaries, demonstrating that removing the unused fields does not affect pipeline behavior. |
api/v2alpha1/pipeline_spec.proto
Outdated
|
|
||
| // Time to live configuration after the pipeline run is completed for | ||
| // ephemeral resources created by the pipeline run. | ||
| int32 resource_ttl = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on your manual verification, it sounds like we can reorder these to 1 and 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, yet to push the updated code. Currently working on some final code changes
Signed-off-by: sduvvuri1603 <[email protected]>
Signed-off-by: sduvvuri1603 <[email protected]>
96a5982 to
cf0b4e0
Compare
Description of your changes:
-Next Steps