Skip to content

Conversation

@sduvvuri1603
Copy link
Contributor

Description of your changes:

  • Removes the unused semaphore_key and mutex_name options from dsl.PipelineConfig and related compiler wiring.
  • Deletes the legacy sample pipeline plus golden YAMLs that referenced those fields.
  • Updates the v2 proto schema (and regenerated Go/Python bindings, backend fixtures, and docs) to drop the fields entirely.
  • Leaves the new pipeline_run_parallelism work for a follow-up PR (as tracked in RHOAIENG-13108).

-Next Steps

  • Follow-up PR will introduce pipeline_run_parallelism, backend ConfigMap management, and tests per RHOAIENG-13108.

@google-oss-prow
Copy link

Hi @sduvvuri1603. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sduvvuri1603 sduvvuri1603 force-pushed the Mutex_Semaphore_Delete_Temp branch 2 times, most recently from 113015d to 67a1721 Compare October 30, 2025 18:20
@sduvvuri1603 sduvvuri1603 force-pushed the Mutex_Semaphore_Delete_Temp branch 2 times, most recently from 2316005 to c32d84f Compare October 30, 2025 19:53
@sduvvuri1603 sduvvuri1603 marked this pull request as ready for review October 30, 2025 21:46
@alyssacgoins
Copy link
Contributor

/ok-to-test

@sduvvuri1603 sduvvuri1603 force-pushed the Mutex_Semaphore_Delete_Temp branch from c32d84f to feedbf7 Compare November 3, 2025 18:19
@google-oss-prow google-oss-prow bot added size/XS and removed size/XL labels Nov 3, 2025
@sduvvuri1603 sduvvuri1603 reopened this Nov 3, 2025
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sduvvuri1603 sduvvuri1603 force-pushed the Mutex_Semaphore_Delete_Temp branch from e6f4751 to abd8b2d Compare November 3, 2025 20:00
@google-oss-prow google-oss-prow bot added size/XXL and removed size/XL labels Nov 3, 2025
@sduvvuri1603 sduvvuri1603 force-pushed the Mutex_Semaphore_Delete_Temp branch from abd8b2d to 96a5982 Compare November 3, 2025 20:07
@sduvvuri1603 sduvvuri1603 marked this pull request as draft November 4, 2025 15:27
@sduvvuri1603
Copy link
Contributor Author

Manual verification

Environment prep:

  • Built a local image local/python-kfp:3.11-kfp2146 (python:3.11 + kfp==2.14.6) and loaded it into the Kind cluster.
  • Updated pipeline_with_workspace.py temporarily to reference that image.
  • Rebuilt and reloaded kfp-driver and kfp-launcher.

Baseline (before removing semaphore_key / mutex_name):

  • Pipeline version: temp pipeline
  • Run: Run of temp pipeline (a2413) – succeeded

After removal and rebuilt components:

  • Pipeline version: temp pipeline-version-at-2025-11-05t19-19-55.684z
  • Run: Run of temp pipeline-version-at-2025-11-05t19-19-55.684z – succeeded

Both runs use the same pipeline definition (identical workspace configuration); the only difference is the backend binaries, demonstrating that removing the unused fields does not affect pipeline behavior.

@mprahl mprahl marked this pull request as ready for review November 5, 2025 21:11
@google-oss-prow google-oss-prow bot requested a review from zazulam November 5, 2025 21:11

// Time to live configuration after the pipeline run is completed for
// ephemeral resources created by the pipeline run.
int32 resource_ttl = 3;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on your manual verification, it sounds like we can reorder these to 1 and 2.

Copy link
Contributor Author

@sduvvuri1603 sduvvuri1603 Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, yet to push the updated code. Currently working on some final code changes

@sduvvuri1603 sduvvuri1603 force-pushed the Mutex_Semaphore_Delete_Temp branch from 96a5982 to cf0b4e0 Compare November 5, 2025 22:38
@sduvvuri1603 sduvvuri1603 marked this pull request as draft November 5, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants