Skip to content

Commit abd8b2d

Browse files
sduvvuri1603sduvvuri1603
committed
Remove unused semaphore/mutex pipeline config
Signed-off-by: sduvvuri1603 <[email protected]>
1 parent bc4a4c5 commit abd8b2d

26 files changed

+287
-854
lines changed

‎api/v2alpha1/go/pipelinespec/pipeline_spec.pb.go‎

Lines changed: 2 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎api/v2alpha1/pipeline_spec.proto‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1166,12 +1166,6 @@ message KubernetesWorkspaceConfig {
11661166

11671167
// Spec for pipeline-level config options. See PipelineConfig DSL class.
11681168
message PipelineConfig {
1169-
// Name of the semaphore key to control pipeline concurrency
1170-
string semaphore_key = 1;
1171-
1172-
// Name of the mutex to ensure mutual exclusion
1173-
string mutex_name = 2;
1174-
11751169
// Time to live configuration after the pipeline run is completed for
11761170
// ephemeral resources created by the pipeline run.
11771171
int32 resource_ttl = 3;

‎backend/test/proto_tests/objects.go‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -306,9 +306,7 @@ var platformSpec = &specPB.PlatformSpec{
306306
},
307307
},
308308
PipelineConfig: &specPB.PipelineConfig{
309-
SemaphoreKey: "test-key",
310-
MutexName: "test-mutex",
311-
ResourceTtl: 24,
309+
ResourceTtl: 24,
312310
},
313311
},
314312
},

‎backend/test/proto_tests/testdata/generated-1791485/experiment.json‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
{
2-
"experiment_id": "exp-456",
3-
"display_name": "Production Data Processing Experiment",
4-
"description": "Experiment for testing production data processing pipeline",
5-
"created_at": "2024-01-01T12:00:00Z",
6-
"namespace": "namespace1",
7-
"storage_state": "AVAILABLE",
8-
"last_run_created_at": "2024-01-01T12:00:00Z"
9-
}
2+
"experiment_id": "exp-456",
3+
"display_name": "Production Data Processing Experiment",
4+
"description": "Experiment for testing production data processing pipeline",
5+
"created_at": "2024-01-01T12:00:00Z",
6+
"namespace": "namespace1",
7+
"storage_state": "AVAILABLE",
8+
"last_run_created_at": "2024-01-01T12:00:00Z"
9+
}

‎backend/test/proto_tests/testdata/generated-1791485/pipeline.json‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
{
2-
"pipeline_id": "9b187b86-7c0a-42ae-a0bc-2a746b6eb7a3",
3-
"display_name": "Production Data Processing Pipeline",
4-
"name": "pipeline1",
5-
"description": "Pipeline for processing and analyzing production data",
6-
"created_at": "2024-01-01T12:00:00Z",
7-
"namespace": "namespace1",
8-
"error": {
9-
"code": 0,
10-
"message": "This a successful pipeline.",
11-
"details": []
2+
"pipeline_id": "9b187b86-7c0a-42ae-a0bc-2a746b6eb7a3",
3+
"display_name": "Production Data Processing Pipeline",
4+
"name": "pipeline1",
5+
"description": "Pipeline for processing and analyzing production data",
6+
"created_at": "2024-01-01T12:00:00Z",
7+
"namespace": "namespace1",
8+
"error": {
9+
"code": 0,
10+
"message": "This a successful pipeline.",
11+
"details": []
1212
}
13-
}
13+
}

‎backend/test/proto_tests/testdata/generated-1791485/pipeline_spec.json‎

Lines changed: 84 additions & 84 deletions
Original file line numberDiff line numberDiff line change
@@ -1,115 +1,115 @@
11
{
2-
"pipeline_info": {
3-
"name": "sample-pipeline",
4-
"display_name": "",
5-
"description": "Sample pipeline for testing"
2+
"pipeline_info": {
3+
"name": "sample-pipeline",
4+
"display_name": "",
5+
"description": "Sample pipeline for testing"
66
},
7-
"deployment_spec": {},
8-
"sdk_version": "",
9-
"schema_version": "",
10-
"components": {
11-
"comp-1": {
12-
"input_definitions": {
13-
"artifacts": {},
14-
"parameters": {
15-
"param1": {
16-
"type": "PRIMITIVE_TYPE_UNSPECIFIED",
17-
"parameter_type": "STRING",
18-
"default_value": null,
19-
"is_optional": false,
20-
"description": ""
7+
"deployment_spec": {},
8+
"sdk_version": "",
9+
"schema_version": "",
10+
"components": {
11+
"comp-1": {
12+
"input_definitions": {
13+
"artifacts": {},
14+
"parameters": {
15+
"param1": {
16+
"type": "PRIMITIVE_TYPE_UNSPECIFIED",
17+
"parameter_type": "STRING",
18+
"default_value": null,
19+
"is_optional": false,
20+
"description": ""
2121
}
2222
}
2323
},
24-
"output_definitions": {
25-
"artifacts": {},
26-
"parameters": {
27-
"output1": {
28-
"type": "PRIMITIVE_TYPE_UNSPECIFIED",
29-
"parameter_type": "STRING",
30-
"description": ""
24+
"output_definitions": {
25+
"artifacts": {},
26+
"parameters": {
27+
"output1": {
28+
"type": "PRIMITIVE_TYPE_UNSPECIFIED",
29+
"parameter_type": "STRING",
30+
"description": ""
3131
}
3232
}
3333
},
34-
"dag": {
35-
"tasks": {
36-
"task1": {
37-
"task_info": {
38-
"name": "task1"
34+
"dag": {
35+
"tasks": {
36+
"task1": {
37+
"task_info": {
38+
"name": "task1"
3939
},
40-
"inputs": {
41-
"parameters": {
42-
"param1": {
43-
"component_input_parameter": "param1",
44-
"parameter_expression_selector": ""
40+
"inputs": {
41+
"parameters": {
42+
"param1": {
43+
"component_input_parameter": "param1",
44+
"parameter_expression_selector": ""
4545
}
4646
},
47-
"artifacts": {}
47+
"artifacts": {}
4848
},
49-
"dependent_tasks": [],
50-
"caching_options": null,
51-
"component_ref": {
52-
"name": "comp-1"
49+
"dependent_tasks": [],
50+
"caching_options": null,
51+
"component_ref": {
52+
"name": "comp-1"
5353
},
54-
"trigger_policy": null,
55-
"retry_policy": null,
56-
"iterator_policy": null
54+
"trigger_policy": null,
55+
"retry_policy": null,
56+
"iterator_policy": null
5757
}
5858
},
59-
"outputs": {
60-
"artifacts": {},
61-
"parameters": {
62-
"output1": {
63-
"value_from_parameter": {
64-
"producer_subtask": "foo",
65-
"output_parameter_key": "bar"
59+
"outputs": {
60+
"artifacts": {},
61+
"parameters": {
62+
"output1": {
63+
"value_from_parameter": {
64+
"producer_subtask": "foo",
65+
"output_parameter_key": "bar"
6666
}
6767
}
6868
}
6969
}
7070
},
71-
"single_platform_specs": [],
72-
"task_config_passthroughs": []
71+
"single_platform_specs": [],
72+
"task_config_passthroughs": []
7373
}
7474
},
75-
"root": {
76-
"input_definitions": {
77-
"artifacts": {},
78-
"parameters": {
79-
"input1": {
80-
"type": "PRIMITIVE_TYPE_UNSPECIFIED",
81-
"parameter_type": "STRING",
82-
"default_value": "foo",
83-
"is_optional": false,
84-
"description": ""
75+
"root": {
76+
"input_definitions": {
77+
"artifacts": {},
78+
"parameters": {
79+
"input1": {
80+
"type": "PRIMITIVE_TYPE_UNSPECIFIED",
81+
"parameter_type": "STRING",
82+
"default_value": "foo",
83+
"is_optional": false,
84+
"description": ""
8585
},
86-
"input2": {
87-
"type": "PRIMITIVE_TYPE_UNSPECIFIED",
88-
"parameter_type": "STRING",
89-
"default_value": null,
90-
"is_optional": false,
91-
"description": ""
86+
"input2": {
87+
"type": "PRIMITIVE_TYPE_UNSPECIFIED",
88+
"parameter_type": "STRING",
89+
"default_value": null,
90+
"is_optional": false,
91+
"description": ""
9292
}
9393
}
9494
},
95-
"output_definitions": {
96-
"artifacts": {},
97-
"parameters": {
98-
"output1": {
99-
"type": "PRIMITIVE_TYPE_UNSPECIFIED",
100-
"parameter_type": "STRING",
101-
"description": ""
95+
"output_definitions": {
96+
"artifacts": {},
97+
"parameters": {
98+
"output1": {
99+
"type": "PRIMITIVE_TYPE_UNSPECIFIED",
100+
"parameter_type": "STRING",
101+
"description": ""
102102
},
103-
"output2": {
104-
"type": "PRIMITIVE_TYPE_UNSPECIFIED",
105-
"parameter_type": "NUMBER_INTEGER",
106-
"description": ""
103+
"output2": {
104+
"type": "PRIMITIVE_TYPE_UNSPECIFIED",
105+
"parameter_type": "NUMBER_INTEGER",
106+
"description": ""
107107
}
108108
}
109109
},
110-
"executor_label": "root-executor",
111-
"single_platform_specs": [],
112-
"task_config_passthroughs": []
110+
"executor_label": "root-executor",
111+
"single_platform_specs": [],
112+
"task_config_passthroughs": []
113113
},
114-
"default_pipeline_root": ""
115-
}
114+
"default_pipeline_root": ""
115+
}

‎backend/test/proto_tests/testdata/generated-1791485/pipeline_spec.pb‎

0 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)