Skip to content

Update API version of AdmissionResponse created via invalid call #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clux merged 1 commit into from
Jan 17, 2026
Merged

Update API version of AdmissionResponse created via invalid call #1905

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions kube-core/src/admission.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ pub struct ConvertAdmissionReviewError;
pub const META_KIND: &str = "AdmissionReview";
/// The `api_version` field in [`TypeMeta`] on the v1 version.
pub const META_API_VERSION_V1: &str = "admission.k8s.io/v1";
/// The `api_version` field in [`TypeMeta`] on the v1beta1 version.
pub const META_API_VERSION_V1BETA1: &str = "admission.k8s.io/v1beta1";

/// The top level struct used for Serializing and Deserializing AdmissionReview
/// requests and responses.
Expand Down Expand Up @@ -301,7 +299,7 @@ impl AdmissionResponse {
// supported and we won't be using any of the new fields.
types: TypeMeta {
kind: META_KIND.to_owned(),
api_version: META_API_VERSION_V1BETA1.to_owned(),
api_version: META_API_VERSION_V1.to_owned(),
},
uid: Default::default(),
allowed: false,
Expand Down