Update API version of AdmissionResponse created via invalid call#1905
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1905 +/- ##
=======================================
+ Coverage 76.1% 76.1% +0.1%
=======================================
Files 86 86
Lines 8399 8399
=======================================
+ Hits 6388 6389 +1
+ Misses 2011 2010 -1
🚀 New features to boost your workflow:
|
Magicloud
force-pushed
the
admission_api_version
branch
from
7f25593 to
b0705ba
Compare
The API version is hardcoded to v1beta1, which is obsoleted since K8S v1.22. Giving v1.22 is not supported by kube-rs. Simply update the version is alright. The API versions v1 and v1beta1 are defined in two consts. Update the only place that uses them from v1beta1 to v1, and remove the v1beta1 const. Building passed indicates that there is no other place using v1beta1 const. Signed-off-by: Magicloud <[email protected]>
Magicloud
force-pushed
the
admission_api_version
branch
from
b0705ba to
95bbdc6
Compare
hugoponthieu
pushed a commit
to hugoponthieu/kube
that referenced
this pull request
Jan 29, 2026
…e-rs#1905) The API version is hardcoded to v1beta1, which is obsoleted since K8S v1.22. Giving v1.22 is not supported by kube-rs. Simply update the version is alright. The API versions v1 and v1beta1 are defined in two consts. Update the only place that uses them from v1beta1 to v1, and remove the v1beta1 const. Building passed indicates that there is no other place using v1beta1 const. Signed-off-by: Magicloud <[email protected]>
cchndl
pushed a commit
to cchndl/kube
that referenced
this pull request
Feb 19, 2026
…e-rs#1905) The API version is hardcoded to v1beta1, which is obsoleted since K8S v1.22. Giving v1.22 is not supported by kube-rs. Simply update the version is alright. The API versions v1 and v1beta1 are defined in two consts. Update the only place that uses them from v1beta1 to v1, and remove the v1beta1 const. Building passed indicates that there is no other place using v1beta1 const. Signed-off-by: Magicloud <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API version is hardcoded to v1beta1, which is obsoleted since K8S v1.22. Giving v1.22 is not supported by kube-rs. Simply update the version is alright.
Motivation
Fix #1904
Solution
The API versions v1 and v1beta1 are defined in two consts. Update the only place that uses them from v1beta1 to v1, and remove the v1beta1 const. Building passed indicates that there is no other place using v1beta1 const.