Use io.ReadCloser + json.NewDecoder #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to use json.NewDecoder, we have to operate on an I/O stream. So, we swap out passing around a byteslice for this instead. This means we can't defer closure of the body stream within the `doRawRequest` method and have to unwrap it into individual close statements. But we can in the higher level `doRequest` method. Finally, in `Repository.GetFileBlob`, we utilize `ioutil.ReadAll` to replicate the original functionality to consume the response body.
ktrysmt
approved these changes
Apr 27, 2020
This was referenced Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to take an attempt at #71
To use
json.NewDecoder, we need to use the I/O stream from the HTTP response object.This is merely a starting point.