Skip to content

Conversation

@soult
Copy link
Contributor

@soult soult commented Jan 21, 2022

The Repositories.ListForTeam method calls Client.executeRaw, most likely due to an oversight in PR #88. This means that any calls to this function will fail.

  • Add tests for both ListForAccount and ListForTeam`
  • Deprecate ListForTeam and make it an alias for ListForAccount, since it
    performs exactly the same function/request

soult added 2 commits January 21, 2022 21:26
Make Repositories.GetForTeam an alias to Repositories.GetForAccount, and mark
the former as deprecated, since they both do the same.
Copy link
Owner

@ktrysmt ktrysmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ktrysmt ktrysmt merged commit ff2633c into ktrysmt:master Jan 25, 2022
@soult soult deleted the GH-181/repositories_list_for_team branch June 18, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants