Fix issue with fork_policy not being updated
#168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests pass including the new ones |
Due to an undocumented quirk in Bitbucket's API, when updating a repository, you have to pass in two additional fields which are then used together, to match the string representation of the fork_policy (which the API returns - the other two fields are not returned). Here is a link to an oustanding bug ticket filed with Atlassian: https://jira.atlassian.com/browse/BCLOUD-13093 Also added tests to cover the behaviour above, as well as an additional one for creating a repository, to ensure this functionality was not broken with the changes introduced.
zahiar
force-pushed
the
fix-repo-fork-policy-update
branch
from
1a42ba0 to
9992407
Compare
zahiar
referenced
this pull request
in zahiar/terraform-provider-bitbucket
Nov 14, 2021
This includes two PRs: 1. To add functionality to support `deploy-keys` - `https://github.com/ktrysmt/go-bitbucket/pull/167` 2. To fix a bug with `fork_policy` not being updated after initially being set - `https://github.com/ktrysmt/go-bitbucket/pull/168`
zahiar
referenced
this pull request
in zahiar/terraform-provider-bitbucket
Nov 14, 2021
* GH-29 Add deploy key resource & data source Along with docs. * GH-29 Update `go-bitbucket` to latest version This includes two PRs: 1. To add functionality to support `deploy-keys` - `https://github.com/ktrysmt/go-bitbucket/pull/167` 2. To fix a bug with `fork_policy` not being updated after initially being set - `https://github.com/ktrysmt/go-bitbucket/pull/168`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an undocumented quirk in Bitbucket's API, when updating a repository, you have to pass in two additional fields which are then used together, to match the string representation of the fork_policy (which the API returns - the other two fields are not returned).
Here is a link to an oustanding bug ticket filed with Atlassian: https://jira.atlassian.com/browse/BCLOUD-13093
Also added tests to cover the behaviour above, as well as an additional one for creating a repository, to ensure this functionality was not broken with the changes introduced.