Repository fork_policy does not get updated after the initial apply

[zahiar]

After you create a repository using the bitbucket_repository resource, any changes made to fork_policy do not appear to go through. The original value remains.

Please investigate as to why this is happening, it could be due to the underlying go-bitbucket module not correctly handling this.

Terraform code to reproduce

resource "bitbucket_repository" "za" {
  workspace = data.bitbucket_workspace.za.id
  name = "abc-def"
  project_key = bitbucket_project.za-test.key
  fork_policy = "no_public_forks"
}

After applying that, change fork_policy

resource "bitbucket_repository" "za" {
  workspace = data.bitbucket_workspace.za.id
  name = "abc-def"
  project_key = bitbucket_project.za-test.key
  fork_policy = "no_forks"
}

The latter no_forks fork policy will not be made, despite Terraform saying success - this can be verified by re-running the plan which will show the same diff or by going into Bitbucket and viewing the fork policy on the repository.

[zahiar]

After coming across https://jira.atlassian.com/browse/BCLOUD-13093 - the API (PUT) handles the fork policy updates in an asymmetric fashion. So instead of doing fork_policy: no_forks, you instead specify two boolean fields, which Bitbucket's API then maps to either no_forks, allow_forks or no_public_forks, which is then returned by the API (& by the other endpoints like GET repository).

The update behaviour follows like so:

1. Only allow private forks

curl --user username:app-password --request PUT \
  --url https://api.bitbucket.org/2.0/repositories/workspace/repository \
  --header 'content-type: application/json' \
  --data '{ 
	"no_forks": "false",
        "no_public_forks": "true"
}'

2. No forks

curl --user username:app-password --request PUT \
  --url https://api.bitbucket.org/2.0/repositories/workspace/repository \
  --header 'content-type: application/json' \
  --data '{ 
	"no_forks": "true",
        "no_public_forks": "true"
}'

3. Allow forks

curl --user username:app-password --request PUT \
  --url https://api.bitbucket.org/2.0/repositories/workspace/repository \
  --header 'content-type: application/json' \
  --data '{ 
	"no_forks": "false",
        "no_public_forks": "false"
}'

[zahiar]

Pull request raised with go-bitbucket: ktrysmt/go-bitbucket#168