Skip to content

🐛 Fix oauth to work with external access networkpolicy #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025
Merged

🐛 Fix oauth to work with external access networkpolicy #418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion roles/tackle/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ oauth_provider: openshift
oauth_default_openshift_sar: --openshift-sar={"namespace":"{{ app_namespace }}","resource":"services","resourceName":"{{ ui_service_name }}","verb":"get"}
oauth_access_rule: "{{ oauth_default_openshift_sar if oauth_provider == 'openshift' }}"
oauth_image_fqin: "{{ lookup('env', 'RELATED_IMAGE_OAUTH_PROXY') }}"
oauth_ssl_port: 9443
oauth_ssl_port: 8443
Copy link
Member

@djzager djzager Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is it? Why?

Copy link
Member Author

@jmontleon jmontleon Mar 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment on the PR for main, apologies, I did not include it on this one:
The external access network policy allows 8080 and 8443. So using 8443 instead of 9443 allows everything to work.

I think my PR to add the oauth proxy predated the networkpolicy, so the auth proxy listening on 9443 at the time worked. That is no longer true as the traffic gets blocked. Alternatively I could have added port 9443 to the networkpolicy, but I went with this route.

Copy link
Member

@djzager djzager Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh. I saw it and didn't connect them.


admin_name: "admin"

Expand Down
Loading