Skip to content

✨ Feature/document change listeners #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 30, 2025
Merged

✨ Feature/document change listeners #814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
caf0702
:ghost: updated external provider deps
pranavgaikwad Apr 29, 2025
3b7f672
:sparkles: introduce NotifyFileChange() api to providers
pranavgaikwad Apr 10, 2025
3dbfd89
:ghost: implement NotifyFileChanges() in fake providers
pranavgaikwad Apr 10, 2025
0c89260
:sparkles: regenerate protobuf spec with NotifyFileChanges()
pranavgaikwad Apr 10, 2025
98c486d
:sparkles: implement NotifyFileChanges() in base grpc
pranavgaikwad Apr 10, 2025
c79b042
:sparkles: implement NotifyFileChanges() api stub in external providers
pranavgaikwad Apr 10, 2025
de525d3
:star: refactor / consolidate file search and include / excludes
pranavgaikwad Apr 12, 2025
daf1913
:sparkles: implement working copy manager for builtin provider
pranavgaikwad Apr 12, 2025
ea78d83
:ghost: fixups in wcm and improve search logic
pranavgaikwad Apr 12, 2025
3ae9da7
:ghost: cond.Filepaths must match filenames as well as full paths
pranavgaikwad Apr 14, 2025
5cbbeec
:bug: minor fixup
pranavgaikwad Apr 15, 2025
85b88ae
:bug: fix /suffix/prefix/ wherever paths were handled, add logs
pranavgaikwad Apr 17, 2025
f940441
:ghost: add log to yq
pranavgaikwad Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion external-providers/dotnet-external-provider/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module github.com/konveyor/analyzer-lsp/external-providers/dotnet-external-provi
go 1.21

require (
github.com/konveyor/analyzer-lsp v0.5.0-rc.1.0.20240729200152-daea76a602fd
github.com/konveyor/analyzer-lsp v0.7.0-alpha.2.0.20250429204526-42a42086434d
go.lsp.dev/jsonrpc2 v0.10.0
go.lsp.dev/protocol v0.12.0
go.lsp.dev/uri v0.3.0
Expand Down
4 changes: 2 additions & 2 deletions external-providers/dotnet-external-provider/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ github.com/hashicorp/go-version v1.6.0 h1:feTTfFNnjP967rlCxM/I9g701jU+RN74YKx2mO
github.com/hashicorp/go-version v1.6.0/go.mod h1:fltr4n8CU8Ke44wwGCBoEymUuxUHl09ZGVZPK5anwXA=
github.com/iancoleman/orderedmap v0.3.0 h1:5cbR2grmZR/DiVt+VJopEhtVs9YGInGIxAoMJn+Ichc=
github.com/iancoleman/orderedmap v0.3.0/go.mod h1:XuLcCUkdL5owUCQeF2Ue9uuw1EptkJDkXXS7VoV7XGE=
github.com/konveyor/analyzer-lsp v0.5.0-rc.1.0.20240729200152-daea76a602fd h1:mDu+2r8AIDxoIQ8UrGFT3AYygPBZFfQOVL3YfJIPkMw=
github.com/konveyor/analyzer-lsp v0.5.0-rc.1.0.20240729200152-daea76a602fd/go.mod h1:Gqj6MRUA2Jjjw19tUguJB6Bqj4dLwZzb68FmAUok0ac=
github.com/konveyor/analyzer-lsp v0.7.0-alpha.2.0.20250429204526-42a42086434d h1:M504NQnmUFJ/zrPz+fXBQg8oJ23SRfKOk3wxl1PIH80=
github.com/konveyor/analyzer-lsp v0.7.0-alpha.2.0.20250429204526-42a42086434d/go.mod h1:nlSmohI+wwPTzvWXAtHI3PXe7B9RRU5NKnqnu222Ia0=
github.com/kr/pretty v0.2.1/go.mod h1:ipq/a2n7PKx3OHsz4KJII5eveXtPO4qwEXGdVfWzfnI=
github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=
github.com/kr/pretty v0.3.1/go.mod h1:hoEshYVHaxMs3cyo3Yncou5ZscifuDolrwPKZanG3xk=
Expand Down
4 changes: 4 additions & 0 deletions external-providers/dotnet-external-provider/pkg/dotnet/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,3 +195,7 @@ func (p *dotnetProvider) Init(ctx context.Context, log logr.Logger, config provi
config: config,
}, provider.InitConfig{}, nil
}

func (d *dotnetProvider) NotifyFileChanges(ctx context.Context, changes ...provider.FileChange) error {
return nil
}
4 changes: 4 additions & 0 deletions external-providers/dotnet-external-provider/pkg/dotnet/service_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,10 @@ func (d *dotnetServiceClient) GetDependenciesDAG(ctx context.Context) (map[uri.U
return map[uri.URI][]provider.DepDAGItem{}, nil
}

func (d *dotnetServiceClient) NotifyFileChanges(ctx context.Context, changes ...provider.FileChange) error {
return nil
}

// this is a struct for providing the server that lives on the client side
// of the connection to properly respond to requests sent server -> client
type handler struct {
Expand Down
2 changes: 1 addition & 1 deletion external-providers/generic-external-provider/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ go 1.21
require (
github.com/bombsimon/logrusr/v3 v3.1.0
github.com/go-logr/logr v1.4.2
github.com/konveyor/analyzer-lsp v0.5.0-rc.1.0.20240729200152-daea76a602fd
github.com/konveyor/analyzer-lsp v0.7.0-alpha.2.0.20250429204526-42a42086434d
github.com/sirupsen/logrus v1.9.3
github.com/swaggest/openapi-go v0.2.45
go.lsp.dev/uri v0.3.0
Expand Down
4 changes: 2 additions & 2 deletions external-providers/generic-external-provider/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ github.com/hashicorp/go-version v1.6.0 h1:feTTfFNnjP967rlCxM/I9g701jU+RN74YKx2mO
github.com/hashicorp/go-version v1.6.0/go.mod h1:fltr4n8CU8Ke44wwGCBoEymUuxUHl09ZGVZPK5anwXA=
github.com/iancoleman/orderedmap v0.3.0 h1:5cbR2grmZR/DiVt+VJopEhtVs9YGInGIxAoMJn+Ichc=
github.com/iancoleman/orderedmap v0.3.0/go.mod h1:XuLcCUkdL5owUCQeF2Ue9uuw1EptkJDkXXS7VoV7XGE=
github.com/konveyor/analyzer-lsp v0.5.0-rc.1.0.20240729200152-daea76a602fd h1:mDu+2r8AIDxoIQ8UrGFT3AYygPBZFfQOVL3YfJIPkMw=
github.com/konveyor/analyzer-lsp v0.5.0-rc.1.0.20240729200152-daea76a602fd/go.mod h1:Gqj6MRUA2Jjjw19tUguJB6Bqj4dLwZzb68FmAUok0ac=
github.com/konveyor/analyzer-lsp v0.7.0-alpha.2.0.20250429204526-42a42086434d h1:M504NQnmUFJ/zrPz+fXBQg8oJ23SRfKOk3wxl1PIH80=
github.com/konveyor/analyzer-lsp v0.7.0-alpha.2.0.20250429204526-42a42086434d/go.mod h1:nlSmohI+wwPTzvWXAtHI3PXe7B9RRU5NKnqnu222Ia0=
github.com/kr/pretty v0.2.1/go.mod h1:ipq/a2n7PKx3OHsz4KJII5eveXtPO4qwEXGdVfWzfnI=
github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=
github.com/kr/pretty v0.3.1/go.mod h1:hoEshYVHaxMs3cyo3Yncou5ZscifuDolrwPKZanG3xk=
Expand Down
2 changes: 1 addition & 1 deletion external-providers/golang-dependency-provider/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module github.com/konveyor/analyzer-lsp/external-providers/golang-dependency-pro
go 1.21

require (
github.com/konveyor/analyzer-lsp v0.5.0-rc.1.0.20240729200152-daea76a602fd
github.com/konveyor/analyzer-lsp v0.7.0-alpha.2.0.20250429204526-42a42086434d
go.lsp.dev/uri v0.3.0
google.golang.org/grpc v1.67.3 // indirect
)
Expand Down
4 changes: 2 additions & 2 deletions external-providers/golang-dependency-provider/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ github.com/hashicorp/go-version v1.6.0 h1:feTTfFNnjP967rlCxM/I9g701jU+RN74YKx2mO
github.com/hashicorp/go-version v1.6.0/go.mod h1:fltr4n8CU8Ke44wwGCBoEymUuxUHl09ZGVZPK5anwXA=
github.com/iancoleman/orderedmap v0.3.0 h1:5cbR2grmZR/DiVt+VJopEhtVs9YGInGIxAoMJn+Ichc=
github.com/iancoleman/orderedmap v0.3.0/go.mod h1:XuLcCUkdL5owUCQeF2Ue9uuw1EptkJDkXXS7VoV7XGE=
github.com/konveyor/analyzer-lsp v0.5.0-rc.1.0.20240729200152-daea76a602fd h1:mDu+2r8AIDxoIQ8UrGFT3AYygPBZFfQOVL3YfJIPkMw=
github.com/konveyor/analyzer-lsp v0.5.0-rc.1.0.20240729200152-daea76a602fd/go.mod h1:Gqj6MRUA2Jjjw19tUguJB6Bqj4dLwZzb68FmAUok0ac=
github.com/konveyor/analyzer-lsp v0.7.0-alpha.2.0.20250429204526-42a42086434d h1:M504NQnmUFJ/zrPz+fXBQg8oJ23SRfKOk3wxl1PIH80=
github.com/konveyor/analyzer-lsp v0.7.0-alpha.2.0.20250429204526-42a42086434d/go.mod h1:nlSmohI+wwPTzvWXAtHI3PXe7B9RRU5NKnqnu222Ia0=
github.com/kr/pretty v0.2.1/go.mod h1:ipq/a2n7PKx3OHsz4KJII5eveXtPO4qwEXGdVfWzfnI=
github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=
github.com/kr/pretty v0.3.1/go.mod h1:hoEshYVHaxMs3cyo3Yncou5ZscifuDolrwPKZanG3xk=
Expand Down
2 changes: 1 addition & 1 deletion external-providers/java-external-provider/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ go 1.21

require (
github.com/go-logr/logr v1.4.2
github.com/konveyor/analyzer-lsp v0.7.0-alpha.2.0.20250429145255-ccd24834c1dd
github.com/konveyor/analyzer-lsp v0.7.0-alpha.2.0.20250429204526-42a42086434d
github.com/swaggest/openapi-go v0.2.50
go.lsp.dev/uri v0.3.0
go.opentelemetry.io/otel v1.28.0
Expand Down
4 changes: 2 additions & 2 deletions external-providers/java-external-provider/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ github.com/hashicorp/go-version v1.6.0 h1:feTTfFNnjP967rlCxM/I9g701jU+RN74YKx2mO
github.com/hashicorp/go-version v1.6.0/go.mod h1:fltr4n8CU8Ke44wwGCBoEymUuxUHl09ZGVZPK5anwXA=
github.com/iancoleman/orderedmap v0.3.0 h1:5cbR2grmZR/DiVt+VJopEhtVs9YGInGIxAoMJn+Ichc=
github.com/iancoleman/orderedmap v0.3.0/go.mod h1:XuLcCUkdL5owUCQeF2Ue9uuw1EptkJDkXXS7VoV7XGE=
github.com/konveyor/analyzer-lsp v0.7.0-alpha.2.0.20250429145255-ccd24834c1dd h1:bPhZNckRbknEc3vfvG7HLWcQRF4w3Ehqi8X7awszCBs=
github.com/konveyor/analyzer-lsp v0.7.0-alpha.2.0.20250429145255-ccd24834c1dd/go.mod h1:nlSmohI+wwPTzvWXAtHI3PXe7B9RRU5NKnqnu222Ia0=
github.com/konveyor/analyzer-lsp v0.7.0-alpha.2.0.20250429204526-42a42086434d h1:M504NQnmUFJ/zrPz+fXBQg8oJ23SRfKOk3wxl1PIH80=
github.com/konveyor/analyzer-lsp v0.7.0-alpha.2.0.20250429204526-42a42086434d/go.mod h1:nlSmohI+wwPTzvWXAtHI3PXe7B9RRU5NKnqnu222Ia0=
github.com/kr/pretty v0.1.0 h1:L/CwN0zerZDmRFUapSPitk6f+Q3+0za1rQkzVuMiMFI=
github.com/kr/pretty v0.1.0/go.mod h1:dAy3ld7l9f0ibDNOQOHHMYYIIbhfbHSm3C4ZsoJORNo=
github.com/kr/pty v1.1.1/go.mod h1:pFQYn66WHrOpPYNljwOMqo10TkYh1fy3cYio2l3bCsQ=
Expand Down
4 changes: 4 additions & 0 deletions external-providers/java-external-provider/pkg/java_external_provider/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,6 +1006,10 @@ func (p *javaProvider) GetDependenciesDAG(ctx context.Context) (map[uri.URI][]pr
return provider.FullDepDAGResponse(ctx, p.clients)
}

func (p *javaProvider) NotifyFileChanges(ctx context.Context, changes ...provider.FileChange) error {
return provider.FullNotifyFileChangesResponse(ctx, p.clients, changes...)
}

func (p *javaProvider) BuildSettingsFile(m2CacheDir string) (settingsFile string, err error) {
fileContentTemplate := `
<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
Expand Down
9 changes: 7 additions & 2 deletions external-providers/java-external-provider/pkg/java_external_provider/service_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ func (p *javaServiceClient) GetAllSymbols(ctx context.Context, c javaCondition,
if len(p.includedPaths) > 0 {
argumentsMap[provider.IncludedPathsConfigKey] = p.includedPaths
log.V(8).Info("setting search scope by filepaths", "paths", p.includedPaths)
} else if ok, paths := condCTX.GetScopedFilepaths(); ok {
argumentsMap[provider.IncludedPathsConfigKey] = paths
} else if includedPaths, _ := condCTX.GetScopedFilepaths(); len(includedPaths) > 0 {
argumentsMap[provider.IncludedPathsConfigKey] = includedPaths
log.V(8).Info("setting search scope by filepaths", "paths", p.includedPaths, "argumentMap", argumentsMap)
}

Expand Down Expand Up @@ -240,6 +240,11 @@ func (p *javaServiceClient) GetAllReferences(ctx context.Context, symbol protoco
return res
}

// TODO (pgaikwad) - implement this for real
func (p *javaServiceClient) NotifyFileChanges(ctx context.Context, changes ...provider.FileChange) error {
return nil
}

func (p *javaServiceClient) Stop() {
p.cancelFunc()
err := p.cmd.Wait()
Expand Down
30 changes: 17 additions & 13 deletions external-providers/yq-external-provider/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
module github.com/konveyor/analyzer-lsp/external-providers/yq-external-provider

go 1.19
go 1.21

toolchain go1.24.2

require (
github.com/bombsimon/logrusr/v3 v3.1.0
github.com/go-logr/logr v1.2.4
github.com/konveyor/analyzer-lsp v0.5.0-rc.1.0.20240729200152-daea76a602fd
github.com/go-logr/logr v1.4.2
github.com/konveyor/analyzer-lsp v0.7.0-alpha.2.0.20250429204526-42a42086434d
github.com/sirupsen/logrus v1.9.3
github.com/swaggest/openapi-go v0.2.45
go.lsp.dev/uri v0.3.0
Expand All @@ -14,11 +16,13 @@ require (

require (
github.com/golang-jwt/jwt/v5 v5.2.1 // indirect
github.com/google/uuid v1.6.0 // indirect
github.com/kr/text v0.1.0 // indirect
github.com/swaggest/jsonschema-go v0.3.64 // indirect
github.com/swaggest/refl v1.3.0 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20240123012728-ef4313101c80 // indirect
google.golang.org/grpc v1.62.1 // indirect
go.opentelemetry.io/otel/metric v1.28.0 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20240814211410-ddb44dafa142 // indirect
google.golang.org/grpc v1.62.2 // indirect
)

require (
Expand All @@ -28,13 +32,13 @@ require (
github.com/golang/protobuf v1.5.4 // indirect
github.com/hashicorp/go-version v1.6.0 // indirect
github.com/shopspring/decimal v1.3.1 // indirect
go.opentelemetry.io/otel v1.11.2 // indirect
go.opentelemetry.io/otel v1.28.0 // indirect
go.opentelemetry.io/otel/exporters/jaeger v1.11.2 // indirect
go.opentelemetry.io/otel/sdk v1.11.2 // indirect
go.opentelemetry.io/otel/trace v1.11.2 // indirect
golang.org/x/mod v0.8.0
golang.org/x/net v0.24.0 // indirect
golang.org/x/sys v0.22.0 // indirect
golang.org/x/text v0.14.0 // indirect
google.golang.org/protobuf v1.33.1-0.20240408130810-98873a205002 // indirect
go.opentelemetry.io/otel/sdk v1.28.0 // indirect
go.opentelemetry.io/otel/trace v1.28.0 // indirect
golang.org/x/mod v0.17.0
golang.org/x/net v0.28.0 // indirect
golang.org/x/sys v0.28.0 // indirect
golang.org/x/text v0.17.0 // indirect
google.golang.org/protobuf v1.34.2 // indirect
)
Loading
Loading