✨ Feature/document change listeners #814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavgaikwad
added
the
do-not-merge/hold
pranavgaikwad
force-pushed
the
feature/documentChangeListeners
branch
7 times, most recently
from
df16978 to
2787dbe
Compare
pranavgaikwad
force-pushed
the
feature/documentChangeListeners
branch
3 times, most recently
from
f310c7f to
45f25f3
Compare
pranavgaikwad
requested review from
eemcmullan,
jmle and
shawn-hurley
and removed request for
eemcmullan,
jmle and
shawn-hurley
pranavgaikwad
force-pushed
the
feature/documentChangeListeners
branch
from
6a035ae to
47f9939
Compare
pranavgaikwad
removed
the
do-not-merge/hold
jortel
added a commit
to konveyor/tackle2-addon-analyzer
that referenced
this pull request
Apr 22, 2025
Build with latest analyzer-lsp konveyor/analyzer-lsp#814 Latest hub with tag category Rank and Username deprecated. Signed-off-by: Jeff Ortel <[email protected]>
fabianvf
approved these changes
Apr 29, 2025
Contributor
fabianvf
left a comment
fabianvf
left a comment
There was a problem hiding this comment.
This is clean, I like it. I saw a few TODOs/unimplemented change listeners, if that's not a big deal then LGTM
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
pranavgaikwad
force-pushed
the
feature/documentChangeListeners
branch
from
47f9939 to
914cfa0
Compare
Signed-off-by: Pranav Gaikwad <[email protected]>
pranavgaikwad
force-pushed
the
feature/documentChangeListeners
branch
from
914cfa0 to
f940441
Compare
This was referenced May 21, 2025
This was referenced Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Tests PR: 270
This PR introduces new API NotifyFileChanges() in the providers. It is supposed to be used to send changes to files that happen in the editor.
Currently, the api is implemented by the builtin provider where - it introduces a new working copy manager that listens for file changes and writes changes to a temp location. It then uses these new paths to make additional search and excludes the original paths. As soon as a file is saved, the temp copies are discarded.
It uses inclusion / exclusion constraints dynamically; I also refactored how we were using include / exclude and doing file searches as the logic was duplicated in different conditions. I consolidated all that under FileSearcher