Skip to content

CU-86c6f95ug Add permissions to patch HPAs and KEDA ScaledObjects #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iOrcohen merged 2 commits into from
Dec 8, 2025
Merged

CU-86c6f95ug Add permissions to patch HPAs and KEDA ScaledObjects #473

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
754d9f2
chore: update RBAC rules to include horizontalpodautoscalers and scal…
iOrcohen Dec 1, 2025
2101741
chore: remove horizontalpodautoscalers from RBAC rules in admission c…
iOrcohen Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions charts/komodor-agent/templates/admission-controller/rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ rules:
- get
- watch
- list
- patch
- apiGroups:
- "*"
resources:
Expand All @@ -73,6 +74,15 @@ rules:
- pods/resize
verbs:
- patch
- apiGroups:
- keda.sh
resources:
- scaledobjects
Comment on lines +77 to +80
Copy link
Contributor

@OrBin OrBin Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth verifying if you need an API version. If you do - you may need to specify multiple versions or even "*".

Copy link
Contributor

@OrBin OrBin Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you already told me it's unnecessary and actually impossible, I'm approving

verbs:
- get
- watch
- list
- patch

# Required for Admission Controller in-place mutation:
- nonResourceURLs:
Expand Down