CU-86c6f95ug Add permissions to patch HPAs and KEDA ScaledObjects #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOrcohen
requested review from
MickaelAlliel,
Moran-k and
nirbenator
as code owners
Contributor
|
Linked task to ClickUp! |
OrBin
reviewed
Dec 1, 2025
Comment on lines
+77
to
+80
| - apiGroups: | ||
| - keda.sh | ||
| resources: | ||
| - scaledobjects |
Contributor
There was a problem hiding this comment.
Worth verifying if you need an API version. If you do - you may need to specify multiple versions or even "*".
Contributor
There was a problem hiding this comment.
As you already told me it's unnecessary and actually impossible, I'm approving
OrBin
approved these changes
Dec 1, 2025
iOrcohen
deleted the
CU-86c6f95ug-Add-permissions-to-patch-HPAs-and-KEDA-ScaledObjects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add permissions for Komodor Admission Controller for -