docs: model_selection module docstrings
#732
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
changed the title
model_selection module docstrings
FBruzzesi
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Thanks for the PR @mkalimeri!
The only concern I have is related to the part of code in TimeGapSplit summary. @koaning WDYT?
We can keep it as a follow up, but that's certainly not the right assumption to make in this context
1. Updated code in TimeGapSplit: corrected the calculation of total number of days in the fold and added a 'frequency' field in the summary, to show the frequency of the data 2. Updated TimeGapSplit example: data frequency is now in hours and the parameters are in days. 3. Updated pytest for summary calculation
|
I updated the code based on the feedback from the previous review. I kept the summary field 'num of days' and updated the calculation to reflect the actual number of days. I also added a field 'frequency', to inform about the frequency of the data. I updated example/test to reflect these changes. Let me know if you can think of other informative fields! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #596
Examples added for
Type of change
Checklist:
If you feel your PR is ready for a review, ping @FBruzzesi or @koaning.