Detect the right design set for vcard3 #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8921649271Details
💛 - Coveralls |
kesselb
added a commit
to nextcloud/contacts
that referenced
this pull request
Jul 20, 2025
There was a bug in sabre/vobject that stopped us from storing URIs with phone numbers. So, we had to use a workaround and not include them.[^1] The fix for sabre/vobject is merged and included in stable31 and stable30.[^2] It seems like this problem started after updating to ical.js 2.2.0 because of fixes in how vcard3 design sets were detected.[^3][^4] Now it seems to work, but I don't understand why removing the tel property from the vcard3 design set worked when detecting the design set wasn't working before. ^[1]: #1393 (comment) ^[2]: sabre-io/vobject#486 ^[3]: kewisch/ical.js#680 ^[4]: kewisch/ical.js#363 Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
added a commit
to nextcloud/contacts
that referenced
this pull request
Jul 20, 2025
There was a bug in sabre/vobject that stopped us from storing URIs with phone numbers. So, we had to use a workaround and not include them.[^1] The fix for sabre/vobject is merged and included in stable31 and stable30.[^2] It seems like this problem started after updating to ical.js 2.2.0 because of fixes in how vcard3 design sets were detected.[^3][^4] Now it seems to work, but I don't understand why removing the tel property from the vcard3 design set worked when detecting the design set wasn't working before. [^1]: #1393 (comment) [^2]: sabre-io/vobject#486 [^3]: kewisch/ical.js#680 [^4]: kewisch/ical.js#363 Signed-off-by: Daniel Kesselberg <[email protected]>
backportbot bot
pushed a commit
to nextcloud/contacts
that referenced
this pull request
Jul 21, 2025
There was a bug in sabre/vobject that stopped us from storing URIs with phone numbers. So, we had to use a workaround and not include them.[^1] The fix for sabre/vobject is merged and included in stable31 and stable30.[^2] It seems like this problem started after updating to ical.js 2.2.0 because of fixes in how vcard3 design sets were detected.[^3][^4] Now it seems to work, but I don't understand why removing the tel property from the vcard3 design set worked when detecting the design set wasn't working before. [^1]: #1393 (comment) [^2]: sabre-io/vobject#486 [^3]: kewisch/ical.js#680 [^4]: kewisch/ical.js#363 Signed-off-by: Daniel Kesselberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #363
I don't see a better way to adjust the design set than to modify the getter. ICAL.parse() detects the design set but only returns jCal, so it needs to be somewhere in the component code.