fix: rendering of phone numbers

There was a bug in sabre/vobject that stopped us from storing URIs with phone numbers. So, we had to use a workaround and not include them.[^1]

The fix for sabre/vobject is merged and included in stable31 and stable30.[^2]

It seems like this problem started after updating to ical.js 2.2.0 because of fixes in how vcard3 design sets were detected.[^3][^4]

Now it seems to work, but I don't understand why removing the tel property from the vcard3 design set worked when detecting the design set wasn't working before.

[^1]: #1393 (comment)
[^2]: sabre-io/vobject#486
[^3]: kewisch/ical.js#680
[^4]: kewisch/ical.js#363

Signed-off-by: Daniel Kesselberg <[email protected]>

Author: kesselb

src/services/updateDesignSet.js

@@ -4,23 +4,6 @@
  */
 import ICAL from 'ical.js'
 
-/**
- * Prevents ical.js from adding 'VALUE=PHONE-NUMBER' in vCard 3.0.
- * While not wrong according to the RFC, there's a bug in sabreio/vobject (used
- * by Nextcloud Server) that prevents saving vCards with this parameters.
- *
- * @link https://github.com/nextcloud/contacts/pull/1393#issuecomment-570945735
- * @return {boolean} Whether or not the design set has been altered.
- */
-const removePhoneNumberValueType = () => {
-	if (ICAL.design.vcard3.property.tel) {
-		delete ICAL.design.vcard3.property.tel
-		return true
-	}
-
-	return false
-}
-
 /**
  * Some clients group properties by naming them something like 'ITEM1.URL'.
  * These should be treated the same as their original (i.e. 'URL' in this
@@ -78,7 +61,6 @@ export default function(vCard) {
 	let madeChanges = false
 
 	madeChanges |= setTypeMultiValueSeparateDQuote()
-	madeChanges |= removePhoneNumberValueType()
 	madeChanges |= addGroupedProperties(vCard)
 
 	return madeChanges