Skip to content

Conversation

@tirthasheshpatel
Copy link
Contributor

Locally, BasNet tests consume around 12GB of memory on CPU. This PR reduces the memory consumption by scaling down the input sizes and batch size. Some GPU tests on Kokoro are failing with a "Fatal Python error" which might be due to excess memory usage.

@divyashreepathihalli @sampathweb Let's see if the GPU tests pass now. If not, I will try to go deeper into the failure and update the fix.

Copy link
Collaborator

@sampathweb sampathweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@sampathweb sampathweb merged commit c67a0c7 into keras-team:master Jan 30, 2024
@tirthasheshpatel tirthasheshpatel deleted the basnet-memory-fix branch January 30, 2024 22:39
sampathweb added a commit that referenced this pull request Jan 31, 2024
* Move keras-cv markdown files to toplevel (#2291)

Keras, KerasNLP and KerasTuner all store things liek the CONTRIBUTING.md
in the toplevel of the repo. We should do the same here.

* Add `version()` API to unify with Keras and KerasNLP (#2199)

* Unify `version` API with keras and keras_nlp

* Formatting

* Update to keep `version` parity with KerasNLP, support nightly version string

* Update version_utils.py

* Update version_utils.py

* Update random_crop_and_zoom.py (#2294)

* Update random_crop_and_zoom.py

* Update description

* rename file

* bug fix (#2303)

* Add BASNet Segmentation Model (#2006) (#2271)

* BASNet model initial code structure

* adding test and initial preset details

* adding comments

* cleaning and formatting code

* keras 3 support added

* disabling preset test for BASNet

* Fix image.shape type (#2305)

Fixed image.shape issue for tensorflow backend

* Create workflow for auto assignment of issues and for stale issues (#2313)

* Create auto-assignment.yaml

* Create auto-assignment.js

* Create stale-issue-pr.yaml

* Rename auto-assignment.yaml to auto-assignment.yml

* Rename stale-issue-pr.yaml to stale-issue-pr.yml

* Fix format and Update Vectorized Base (#2323)

* Fix CI Test for Basnet OOM and PyCoCo Test Failure for JAX (#2322)

* Reduce memory consumption for BasNet tests (#2325)

---------

Co-authored-by: Matt Watson <[email protected]>
Co-authored-by: Gabriel Rasskin <[email protected]>
Co-authored-by: Sachin Prasad <[email protected]>
Co-authored-by: Haifeng Jin <[email protected]>
Co-authored-by: Hamid Ali <[email protected]>
Co-authored-by: Tirth Patel <[email protected]>
yuvraj-wale pushed a commit to yuvraj-wale/keras-cv that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants