Skip to content

Conversation

@estela-ramirez
Copy link
Contributor

@estela-ramirez estela-ramirez commented May 12, 2025

What type of PR is this?

  • Bug fix (non-breaking change which fixes an issue)
  • Feature/Enhancement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test updates
  • CI/CD related changes
  • Dependency upgrade

Description

Related issue(s)

High-level overview of changes

part of #7469
Configures Instance Manager to work with AL2023 AMIs.
Adds controller flag amazon-linux-os-family to specify which Amazon Linux OS Version User Data to use when the IG does not have a valid os family annotation "instancemgr.keikoproj.io/os-family"

Testing performed

tested on dev cluster
Screenshot 2025-05-12 at 2 34 36 PM

Checklist

  • I've read the CONTRIBUTING doc
  • I've added/updated tests that prove my fix is effective or that my feature works
  • I've added necessary documentation (if appropriate)
  • I've run make test locally and all tests pass
  • I've signed-off my commits with git commit -s for DCO verification
  • I've updated any relevant documentation
  • Code follows the style guidelines of this project

Additional information

@estela-ramirez estela-ramirez requested review from a team as code owners May 12, 2025 16:27
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2025

Codecov Report

Attention: Patch coverage is 84.72222% with 11 lines in your changes missing coverage. Please review.

Project coverage is 46.48%. Comparing base (1c41cef) to head (3a50cf6).

Files with missing lines Patch % Lines
controllers/provisioners/eks/helpers.go 88.05% 7 Missing and 1 partial ⚠️
controllers/provisioners/eks/eks.go 50.00% 1 Missing and 1 partial ⚠️
controllers/instancegroup_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #491      +/-   ##
==========================================
+ Coverage   46.13%   46.48%   +0.35%     
==========================================
  Files          40       40              
  Lines        7004     7075      +71     
==========================================
+ Hits         3231     3289      +58     
- Misses       3617     3627      +10     
- Partials      156      159       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@estela-ramirez estela-ramirez force-pushed the add-al2023-support branch 3 times, most recently from b19064a to 17c32d5 Compare May 12, 2025 17:26
Signed-off-by: eramirez8 <[email protected]>
Copy link
Contributor

@kevdowney kevdowney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estela-ramirez estela-ramirez marked this pull request as draft May 12, 2025 19:06
@estela-ramirez estela-ramirez marked this pull request as ready for review May 12, 2025 21:29
Copy link

@figo figo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shreyas-badiger shreyas-badiger merged commit 8188aaf into keikoproj:master May 13, 2025
7 checks passed
@estela-ramirez estela-ramirez deleted the add-al2023-support branch May 13, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants