Skip to content

Commit ffed9f2

Browse files
author
eramirez8
committed
trim quotes from override al os family
Signed-off-by: eramirez8 <[email protected]>
1 parent 5b380c5 commit ffed9f2

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

controllers/provisioners/eks/eks.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,18 @@ package eks
1717

1818
import (
1919
"fmt"
20+
"strings"
2021
"sync"
2122

2223
corev1 "k8s.io/api/core/v1"
2324

2425
"github.com/go-logr/logr"
25-
2626
"github.com/keikoproj/instance-manager/api/instancemgr/v1alpha1"
2727
"github.com/keikoproj/instance-manager/controllers/common"
2828
awsprovider "github.com/keikoproj/instance-manager/controllers/providers/aws"
2929
kubeprovider "github.com/keikoproj/instance-manager/controllers/providers/kubernetes"
3030
"github.com/keikoproj/instance-manager/controllers/provisioners"
31+
log "github.com/sirupsen/logrus"
3132
)
3233

3334
const (
@@ -145,14 +146,16 @@ func (ctx *EksInstanceGroupContext) GetOsFamily() string {
145146
instanceGroup = ctx.GetInstanceGroup()
146147
annotations = instanceGroup.GetAnnotations()
147148
)
149+
overrideAmazonLinuxFamily := strings.Trim(ctx.AmazonLinuxOsFamily, "\" ")
148150

149151
if v, exists := annotations[OsFamilyAnnotation]; exists {
150152
if common.ContainsEqualFold(AllowedOsFamilies, v) {
153+
log.Infof("HERE 1")
151154
return annotations[OsFamilyAnnotation]
152155
}
153156
ctx.Log.Info("used unsupported annotation value '%v=%v', will default to 'amazonlinux2', allowed values: %+v", OsFamilyAnnotation, v, AllowedOsFamilies)
154-
} else if common.ContainsEqualFold(AllowedOsFamilies, ctx.AmazonLinuxOsFamily) {
155-
return ctx.AmazonLinuxOsFamily
157+
} else if common.ContainsEqualFold(AllowedOsFamilies, overrideAmazonLinuxFamily) {
158+
return overrideAmazonLinuxFamily
156159
}
157160
return OsFamilyAmazonLinux2
158161
}

controllers/provisioners/eks/helpers.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1288,12 +1288,13 @@ func (ctx *EksInstanceGroupContext) GetEksLatestAmi() (string, error) {
12881288
)
12891289
clusterVersion := state.GetClusterVersion()
12901290
annotations := instanceGroup.GetAnnotations()
1291+
overrideAmazonLinuxFamily := strings.Trim(ctx.AmazonLinuxOsFamily, "\" ")
12911292

12921293
var OSFamily string
12931294
if kubeprovider.HasAnnotation(annotations, OsFamilyAnnotation) {
12941295
OSFamily = annotations[OsFamilyAnnotation]
1295-
} else if ctx.AmazonLinuxOsFamily != "" {
1296-
OSFamily = ctx.AmazonLinuxOsFamily
1296+
} else if overrideAmazonLinuxFamily != "" {
1297+
OSFamily = overrideAmazonLinuxFamily
12971298
} else {
12981299
OSFamily = OsFamilyAmazonLinux2
12991300
}

0 commit comments

Comments
 (0)