Skip to content

Conversation

@tekenstam
Copy link
Member

Overview

This PR implements the changes described in issue #464 to migrate from the deprecated golint to the more modern golangci-lint tool.

Changes

  • Added a minimal .golangci.yml configuration file with essential linters
  • Updated the Makefile to use golangci-lint instead of golint
  • Modified the GitHub workflow to install and run golangci-lint
  • Made linting errors non-blocking initially to allow for a gradual transition

Approach

This implementation takes a gradual approach to the migration:

  1. Linting errors are reported but don't fail builds during the transition
  2. Only a minimal set of linters is enabled initially (govet, gosimple, ineffassign)
  3. The infrastructure is in place to enable more linters in future PRs

Testing

  • Verified that the linting command works correctly locally
  • Confirmed that the linting step in CI won't break existing workflows

Checklist

  • I have signed my commits with git commit -s for DCO
  • I have added tests that prove my fix is effective or that my feature works
  • I have added documentation needed for others to understand my changes

Fixes #464

@tekenstam tekenstam requested review from a team as code owners April 13, 2025 00:59
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.99%. Comparing base (a3d330a) to head (5bfff33).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #465   +/-   ##
=======================================
  Coverage   44.99%   44.99%           
=======================================
  Files          40       40           
  Lines        7017     7017           
=======================================
  Hits         3157     3157           
  Misses       3711     3711           
  Partials      149      149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tekenstam tekenstam merged commit 6495fd7 into master Apr 13, 2025
3 checks passed
@tekenstam tekenstam deleted the switch-to-golangci-lint branch April 13, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Switch from golint to golangci-lint

3 participants