chore: switch from golint to golangci-lint (#465)

* chore: switch from golint to golangci-lint

Signed-off-by: Todd Ekenstam <[email protected]>

* fix: update golangci-lint action to fix CI build

Signed-off-by: Todd Ekenstam <[email protected]>

---------

Signed-off-by: Todd Ekenstam <[email protected]>

Author: tekenstam

.github/workflows/unit-test.yml

@@ -20,6 +20,13 @@ jobs:
     - name: Check out code into the Go module directory
       uses: actions/checkout@v4
 
+    - name: Run golangci-lint
+      uses: golangci/golangci-lint-action@v3
+      with:
+        version: v1.55.2
+        only-new-issues: true
+        args: --timeout=3m
+
     - name: Initialize CodeQL
       uses: github/codeql-action/init@v3
       with:

.golangci.yml

@@ -0,0 +1,6 @@
+---
+linters:
+  enable:
+    - govet
+    - gosimple
+    - ineffassign

Makefile

@@ -125,10 +125,8 @@ endif
 
 .PHONY: lint
 lint: check-go
-	@echo "golint $(LINTARGS)"
-	@for pkg in $(shell go list ./...) ; do \
-		golint $(LINTARGS) $$pkg ; \
-	done
+	@echo "Running golangci-lint"
+	golangci-lint run ./... || echo "Linting errors found - these will be enforced in the future"
 
 .PHONY: clean
 clean: