Skip to content

Add omitted charset setting in base.py #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sean-k1 merged 3 commits into from
Oct 19, 2023
Merged

Add omitted charset setting in base.py #565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
145f400
add charset setting to test setUp
starcat37 Oct 18, 2023
971da34
fix: include test_query_event_latin1 test
starcat37 Oct 18, 2023
24834eb
Merge branch 'julien-duponchelle:main' into fix/tests-charset
starcat37 Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pytest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
pull_request:
workflow_dispatch:
env:
PYTEST_SKIP_OPTION: "not test_no_trailing_rotate_event and not test_end_log_pos and not test_query_event_latin1"
PYTEST_SKIP_OPTION: "not test_no_trailing_rotate_event and not test_end_log_pos"
jobs:
test:
strategy:
Expand Down
1 change: 1 addition & 0 deletions pymysqlreplication/tests/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ def setUp(self, charset="utf8"):
self.execute("DROP DATABASE IF EXISTS pymysqlreplication_test")
self.execute("CREATE DATABASE pymysqlreplication_test")
db = copy.copy(self.database)
db["charset"] = charset
self.connect_conn_control(db)
self.stream = None
self.resetBinLog()
Expand Down