Add omitted charset setting in base.py #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-k1
approved these changes
Oct 19, 2023
Collaborator
sean-k1
left a comment
sean-k1
left a comment
There was a problem hiding this comment.
LGTM! Thanks your hard work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses Issue #564.
To resolve the failing TestLatin1 test, I have added the line
db["charset"] = charsetto base.py.As a result of this change, the charset setting now functions correctly in the TestLatin1 test.
python-mysql-replication/pymysqlreplication/tests/test_basic.py
Lines 1474 to 1476 in 1d2c8ab
With this fix in place, I have also re-included the
test_query_event_latin1test in the pytest suite, as it now passes successfully.