chore: Revert checkstyle 13.3.0 bump and add Java 17 to Jenkinsfile#218
Merged
gounthar merged 2 commits intojenkinsci:masterfrom Mar 4, 2026
Merged
Conversation
Checkstyle 13.3.0 requires Java 17 (class file version 65.0), which breaks the plugin BOM tests that run on Java 11. This reverts the checkstyle version to 13.0.0 and adds a Java 17 configuration to the Jenkinsfile as requested by @MarkEWaite. Fixes jenkinsci#215
gounthar
changed the title
Checkstyle 13.x (both 13.0.0 and 13.3.0) requires Java 21 (class file version 65.0). Downgrade to 12.3.1 which is the last version compatible with Java 17. Verified locally: BUILD SUCCESS with Java 17.0.18-tem.
Contributor
Author
|
Turns out checkstyle 13.0.0 also requires Java 21 (class file version 65.0); the entire 13.x line needs it. Downgraded to 12.3.1 instead, which is the last version compatible with Java 17. Verified locally with Java 17.0.18-tem: |
jonesbusy
approved these changes
Mar 4, 2026
jonesbusy
reviewed
Mar 4, 2026
| configurations: [ | ||
| [platform: 'linux', jdk: 25], | ||
| [platform: 'windows', jdk: 21], | ||
| [platform: 'linux', jdk: 17], |
Contributor
There was a problem hiding this comment.
Considering possible regression (dependency not on the parent) this is a good idea to restore (temporarly JDK 17)
Contributor
|
Up to maintainers, but I would argue in favor of CD for this repo |
Member
|
Hi everyone, a new release has been cut and now available at https://github.com/jenkinsci/gitlab-oauth-plugin/releases/tag/gitlab-oauth-1.28 |
Contributor
Author
|
Thanks a lot, Kris! 👍 |
Member
|
You are welcome, Bruno! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[platform: 'linux', jdk: 17]configuration to the JenkinsfileContext
As reported by @MarkEWaite in #215, the checkstyle 13.3.0 bump is causing BOM test failures:
The error:
UnsupportedClassVersionError: com/puppycrawl/tools/checkstyle/api/CheckstyleException has been compiled by a more recent version of the Java Runtime (class file version 65.0), this version of the Java Runtime only recognizes class file versions up to 61.0Class file version 65.0 = Java 21; the BOM environment tests Java 17 too (version 61.0).
Test plan
cc @MarkEWaite @krisstern; once merged, a new release would be needed to fix the weekly BOM build.