Skip to content

feat: add .nmvrc check and arg-less nvs add #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 16, 2019
Merged

feat: add .nmvrc check and arg-less nvs add #138

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e2e33e9
feat: add .nmvrc check
RichiCoder1 Aug 16, 2019
c3f3c55
mirror file read error handling in nvmrc
RichiCoder1 Aug 16, 2019
e95162f
add docs and test for nvmrc
RichiCoder1 Aug 16, 2019
5cf70db
docs: address feedback and grammar
RichiCoder1 Aug 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/auto.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,15 @@ function findAutoVersionAsync(cwd) {
} catch (e) {
Error.throwIfNot(Error.ENOENT, e, 'Failed to read file: ' + versionFile);
}

// If we don't have a version string, try checking for an .nvmrc file
if (!versionString && !settings.disableNvmrc) {
versionFile = path.join(dir, '.nvmrc');
try {
versionString = fs.readFileSync(versionFile, 'utf8').trim();
} catch (_) { }
}

if (versionString) {
try {
version = NodeVersion.parse(versionString);
Expand Down
3 changes: 3 additions & 0 deletions lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,9 @@ function doCommand(args) {

case 'add':
if (help) return help('add');
if (!args[1]) {
return require('./auto').findAutoVersionAsync();
}
version = parseVersion(args[1]);
return require('./addRemove').addAsync(version);

Expand Down