feat: add .nmvrc check and arg-less nvs add
#138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasongin
reviewed
Aug 16, 2019
Owner
|
Looks good. Tests and docs would be nice too!
Edit: Wait, now that I checked the code I see I did code that compatibility already. Nevermind! |
Contributor
Author
Yup! It looks like you already cover pretty much every readonable .nvmrc case :). I'll add some docs and tests in the morn! |
Contributor
Author
|
Added a light test and some docs & comment updates |
RichiCoder1
commented
Aug 16, 2019
jasongin
reviewed
Aug 16, 2019
jasongin
reviewed
Aug 16, 2019
jasongin
reviewed
Aug 16, 2019
Owner
jasongin
left a comment
jasongin
left a comment
There was a problem hiding this comment.
Looks good, with just those small doc edits.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like you already did a ton of good work in
NodeVersionto ensurenvmcompatibility, so it was just a matter of checking for the presence of an.nvmrcand attempting to use that version.Let me know if you think this is good and I'll add test/docs.
Closes #113;