fix: Auto select model only for active provider

[urmauur]

Describe Your Changes

This pull request refactors the model selection logic in the DropdownModelProvider component to improve reliability and maintainability. The main change is the introduction of a helper function to verify model existence, which simplifies and centralizes the logic for checking if a selected or last-used model is available. Additionally, the default model selection behavior has been adjusted to avoid hardcoded fallbacks.

Model selection logic improvements:

• Added a checkModelExists helper function to centralize and simplify the verification of model existence within active providers.
• Updated the initialization logic to use checkModelExists for both the current model and the last-used model, ensuring only valid models are selected and falling back to an empty selection if not found.
• Removed hardcoded default model selection (llamacpp, llama3.2:3b) in favor of a more flexible fallback to an empty selection when no valid model is available.

Code style and formatting:

• Minor formatting adjustments for readability in the provider filtering logic, without changing behavior.

Fixes Issues

Screen.Recording.2025-08-19.at.14.43.10.mp4

• Closes bug: Disable provider still show up as option in old thread #5659
• Closes #

Self Checklist

• Added relevant comments, esp in complex areas
• Updated docs (for bug fixes / features)
• Created issues for follow-up changes or refactoring needed

---

Important

Refactor DropdownModelProvider.tsx to improve model selection logic by centralizing model existence checks and removing hardcoded defaults.

• Model Selection Logic:
  • Introduce checkModelExists in DropdownModelProvider.tsx to centralize model existence checks.
  • Update initialization to use checkModelExists for current and last-used models, defaulting to empty selection if invalid.
  • Remove hardcoded defaults (llamacpp, llama3.2:3b), using empty selection as fallback.
• Code Style:
  • Minor formatting changes for readability in provider filtering logic.

^{This description was created by for cedf42d. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to cedf42d in 1 minute and 23 seconds. Click for details.

• Reviewed 78 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 4 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. web-app/src/containers/DropdownModelProvider.tsx:81

• Draft comment:
  The new helper function 'checkModelExists' centralizes the model existence check. Consider renaming it (e.g. to 'modelExists') or having it return a boolean to more clearly represent its intended use.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

2. web-app/src/containers/DropdownModelProvider.tsx:92

• Draft comment:
  In the useEffect for initializing the model, the code first calls 'selectModelProvider' with the provided model and then checks its existence to potentially reset the selection. This leads to two consecutive calls. Consider checking the model’s validity before calling 'selectModelProvider' to avoid unnecessary updates.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

3. web-app/src/containers/DropdownModelProvider.tsx:98

• Draft comment:
  For the 'useLastUsedModel' branch, the fallback has been changed from hardcoded values to an empty selection. Ensure that this empty selection aligns with the intended default behavior for new chats when the last-used model is invalid.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

4. web-app/src/containers/DropdownModelProvider.tsx:158

• Draft comment:
  The formatting change in the provider filtering condition improves readability by splitting the conditions across lines. This is stylistically sound; no functional issues detected.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_Tqz0QOb5Rvk9zKN4

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[github-actions]

Barecheck - Code coverage report

Total: 37.58%

Your code coverage diff: 0.00% ▴

Uncovered files and lines

File

Lines

web-app/src/containers/DropdownModelProvider.tsx

38-45, 48-56, 83-86, 93-96, 99-102, 104-106, 127-130, 132-135, 140-141, 151, 153-159, 161, 163-165, 168-169, 171-177, 193, 201-208, 210-214, 225-226, 232-235, 238-239, 241, 249-256, 258-266, 287-289, 302-306, 332-338, 345-347, 352, 354-358, 361-366, 368-378, 380-393, 395-396, 398-399, 404, 409-411, 413, 415-418, 421-437, 439-444, 447, 449, 451-457, 459-469, 471-474, 476-477, 479-483, 485-486, 488, 490

[dinhlongviolin1]

LGTM