chore: revert back to passive mode on windows installer #5934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 2b91162 in 1 minute and 28 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_KY57ljTojpVZ12xx
You can customize 
| ${EndIf} | ||
| ; always run in passive mode | ||
| ; StrCpy $PassiveMode 1 | ||
| StrCpy $PassiveMode 1 |
There was a problem hiding this comment.
Forcing $PassiveMode to 1 unconditionally might override any /P option from the command line. If always enforcing passive mode is intended, consider removing or refactoring the earlier conditional block for clarity.
Barecheck - Code coverage reportTotal: 38.59%Your code coverage diff: -0.01% ▾ ✅ All code changes are covered |
qnixsynapse
approved these changes
Jul 26, 2025
louis-jan
approved these changes
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a minor change to the
src-tauri/tauri.bundle.windows.nsis.templatefile. The change ensures that thePassiveModevariable is always set to1in the.onInitfunction.There's no selection for path or uninstall for now. We'll try to enhance it on upcoming releases
src-tauri/tauri.bundle.windows.nsis.template: Uncommented the line that sets$PassiveModeto1, ensuring it always runs in passive mode.Important
Uncommented line in
src-tauri/tauri.bundle.windows.nsis.templateto ensure Windows installer always runs in passive mode.src-tauri/tauri.bundle.windows.nsis.template, uncommentedStrCpy $PassiveMode 1in.onInitto ensure installer always runs in passive mode.This description was created by
for 2b91162. You can customize this summary. It will automatically update as commits are pushed.