Skip to content

chore: revert back to passive mode on windows installer #5934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2025
Merged

chore: revert back to passive mode on windows installer #5934

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src-tauri/tauri.bundle.windows.nsis.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ Function .onInit
StrCpy $PassiveMode 1
${EndIf}
; always run in passive mode
; StrCpy $PassiveMode 1
StrCpy $PassiveMode 1
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot Jul 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forcing $PassiveMode to 1 unconditionally might override any /P option from the command line. If always enforcing passive mode is intended, consider removing or refactoring the earlier conditional block for clarity.


${GetOptions} $CMDLINE "/NS" $NoShortcutMode
${IfNot} ${Errors}
Expand Down
Loading