Fix time-naming linter violation in search_traces.go#7913
Merged
Conversation
Renames variables to comply with linter rules. Fixes jaegertracing#7911 Signed-off-by: Jonah Kowall <jkowall@kowall.net>
jkowall
added
the
changelog:refactoring
Member
|
The linter message was about minDiration not start/end times. And the linter is not failing on main / CI / for me locally. |
github-actions
Bot
added
the
waiting-for-author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7913 +/- ##
==========================================
- Coverage 95.50% 95.49% -0.02%
==========================================
Files 312 312
Lines 16511 16511
==========================================
- Hits 15769 15767 -2
- Misses 579 580 +1
- Partials 163 164 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a linter violation by renaming time-related variables to comply with the revive linter's time-naming rules. The variables are renamed to follow the min<PropertyName>/max<PropertyName> convention, which is already used elsewhere in the codebase.
Changes:
- Renamed
startTimeMintominStartTimeandstartTimeMaxtomaxStartTimein thebuildQueryfunction - Updated all references to use the new variable names
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Metrics Comparison SummaryTotal changes across all snapshots: 0 Detailed changes per snapshotsummary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
summary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
summary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
summary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
|
yurishkuro
approved these changes
Jan 31, 2026
SoumyaRaikwar
pushed a commit
to SoumyaRaikwar/jaeger
that referenced
this pull request
Feb 13, 2026
) Fixes jaegertracing#7911. Renames variables to comply with linter rules as requested. Signed-off-by: Jonah Kowall <jkowall@kowall.net>
singhvibhanshu
pushed a commit
to singhvibhanshu/jaeger
that referenced
this pull request
Mar 18, 2026
) Fixes jaegertracing#7911. Renames variables to comply with linter rules as requested. Signed-off-by: Jonah Kowall <jkowall@kowall.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7911. Renames variables to comply with linter rules as requested.