[Bug]: Linting fails on main: time-naming violation in search_traces.go

[Anmol202005]

What happened?

Running make lint on the main branch fails, preventing local development and contributions. The linting process exits with an error about incorrect variable naming in search_traces.go, which blocks anyone trying to build or test the project locally.

Steps to reproduce

1. Clone the repository
2. Checkout the latest main branch (commit 3361fcc or later)
3. Run make lint
4. Observe the linting failure with error about durationMin variable naming

Expected behavior

make lint should pass without errors on the main branch.

Relevant log output

INFO [runner] linters took 866.950583ms with stages: goanalysis_metalinter: 833.429466ms 
cmd/jaeger/internal/extension/jaegermcp/internal/handlers/search_traces.go:124:6: time-naming: var durationMin is of type time.Duration; don't use unit-specific suffix "Min" (revive)
        var durationMin, durationMax time.Duration
            ^

Screenshot

Additional context

No response

Jaeger backend version

No response

SDK

No response

Pipeline

No response

Stogage backend

No response

Operating system

No response

Deployment model

No response

Deployment configs

[jkowall]

This is actually an issue, but it's not causing the linting to fail per se. I will implement a PR to rename the function.

Verification Report: Issue #7911

Status: Verified / Confirmed

Summary

The reported issue "[Bug]: Linting fails on main: time-naming violation in search_traces.go" is valid. The code in cmd/jaeger/internal/extension/jaegermcp/internal/handlers/search_traces.go violates the configured revive linter rules.

Evidence

1. Code Violation

File: cmd/jaeger/internal/extension/jaegermcp/internal/handlers/search_traces.go
Line: 124

var durationMin, durationMax time.Duration

The variable durationMin (and durationMax) is of type time.Duration. The revive linter's time-naming rule discourages suffixes like "Min" or "Max" for time.Duration types to avoid confusion with unit-specific names (e.g., Minutes).

2. Linter Configuration

File: .golangci.yml

The revive linter is enabled with enable-all-rules: true. The var-naming rule (which encompasses naming conventions) is disabled, but time-naming is not explicitly disabled, meaning it is active.

    revive:
      severity: error
      enable-all-rules: true
      rules:
        # ...
        - name: var-naming
          disabled: true

Reproduction Findings

• Static Analysis: Confirmed violation via code inspection.
• Local Execution: Running make lint locally in the current environment passed with 0 issues. This behavior discrepancy might be due to:
  • Differences in golangci-lint versions (Local: 1.63.4, CI usually uses latest or specific pinned version).
  • Environment-specific filtering or caching.
  • The rule might be part of a newer revive version not present in the local toolchain.

Conclusion

The issue is TRUE. The code should be updated to comply with the linter rule, likely by renaming durationMin to minDuration or similar, or by explicitly disabling the rule for this line if appropriate (though fixing the name is better).