Skip to content

Conversation

@yurishkuro
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Build the image directly instead of calling much more expensive target
  • Use workflow added in Add SPM integration tests #5640 to run the build
  • Change crossdock target to not build debug image with devle, which is expensive

How was this change tested?

  • make build && make dev

hellspawn679 and others added 8 commits June 17, 2024 02:19
Signed-off-by: mehul gautam <[email protected]>
Signed-off-by: mehul gautam <[email protected]>
Signed-off-by: mehul gautam <[email protected]>
Signed-off-by: mehul gautam <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro requested a review from a team as a code owner June 19, 2024 18:02
@yurishkuro yurishkuro requested a review from jkowall June 19, 2024 18:02
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jun 19, 2024
yurishkuro and others added 4 commits June 19, 2024 14:02
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
@codecov
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.38%. Comparing base (3f6f5fe) to head (834c684).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5663   +/-   ##
=======================================
  Coverage   96.38%   96.38%           
=======================================
  Files         329      329           
  Lines       16056    16056           
=======================================
  Hits        15475    15475           
  Misses        404      404           
  Partials      177      177           
Flag Coverage Δ
badger_v1 8.04% <ø> (ø)
badger_v2 1.92% <ø> (ø)
cassandra-3.x-v1 16.60% <ø> (ø)
cassandra-3.x-v2 1.84% <ø> (ø)
cassandra-4.x-v1 16.60% <ø> (ø)
cassandra-4.x-v2 1.84% <ø> (ø)
elasticsearch-7.x-v1 18.87% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v1 19.06% <ø> (ø)
elasticsearch-8.x-v2 19.05% <ø> (-0.02%) ⬇️
grpc_v1 9.47% <ø> (ø)
grpc_v2 7.49% <ø> (+0.01%) ⬆️
kafka 9.76% <ø> (ø)
opensearch-1.x-v1 18.91% <ø> (-0.02%) ⬇️
opensearch-2.x-v1 18.92% <ø> (+0.01%) ⬆️
opensearch-2.x-v2 18.92% <ø> (+0.01%) ⬆️
unittests 94.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit f5d175b into jaegertracing:main Jun 19, 2024
@yurishkuro yurishkuro deleted the test-spm-build branch June 19, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:ci Change related to continuous integration / testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants