Add target docker-images-jaeger-backend in Makefile #5658
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: FlamingSaint <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5658 +/- ##
==========================================
- Coverage 96.37% 96.36% -0.02%
==========================================
Files 327 327
Lines 16028 16028
==========================================
- Hits 15447 15445 -2
- Misses 404 405 +1
- Partials 177 178 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Jun 19, 2024
Signed-off-by: FlamingSaint <[email protected]>
FlamingSaint
commented
Jun 19, 2024
Makefile.Integration.mk
Outdated
| docker buildx build --target $(TARGET) \ | ||
| --tag $(DOCKER_NAMESPACE)/$$component$(SUFFIX):${DOCKER_TAG} \ | ||
| --build-arg base_image=$(BASE_IMAGE) \ | ||
| --build-arg debug_image=$(DEBUG_IMAGE) \ |
Member
Author
There was a problem hiding this comment.
Should I use the BASE_IMAGE here ?
Member
There was a problem hiding this comment.
You could try. I see that the way Dockerfile is designed you cannot skip building debug image. But the main time is actually spent on building the base debug image (where we need to download and build delve), so maybe it's ok.
yurishkuro
reviewed
Jun 19, 2024
yurishkuro
reviewed
Jun 19, 2024
Signed-off-by: FlamingSaint <[email protected]>
Signed-off-by: FlamingSaint <[email protected]>
Member
|
Superseded by #5663 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
docker-images-jaeger-backendinMakefile.Integration.mkHow was this change tested?
make buildChecklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test