Skip to content

Conversation

@drewcorlin1
Copy link
Contributor

Which problem is this PR solving?

Resolves #2487

Description of the changes

Add the ability to format link variables.

How was this change tested?

Unit tests and by running it locally with the following UI config

const DEFAULT_CONFIG = {
  "linkPatterns": [
    {
      "type": "traces",
      "url": "https://myOpenSearch.com/_dashboards/app/discover#/?_g=(time:(from:'#{startTime | epoch_micros_to_date_iso}',to:'#{endTime | epoch_micros_to_date_iso}'))&_a=(index:filebeat-all,query:(language:kuery,query:'#{traceID}'))",
      "text": "Logs"
    }
  ]
};

Checklist

@drewcorlin1 drewcorlin1 requested a review from a team as a code owner November 15, 2024 02:45
@drewcorlin1 drewcorlin1 requested review from pavolloffay and removed request for a team November 15, 2024 02:45
@drewcorlin1 drewcorlin1 force-pushed the link-parameter-formatting branch from 2aae90b to 4ba33d3 Compare November 15, 2024 02:46
@codecov
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base (a82a96c) to head (1fb2061).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2501   +/-   ##
=======================================
  Coverage   96.61%   96.62%           
=======================================
  Files         254      255    +1     
  Lines        7679     7697   +18     
  Branches     1931     2001   +70     
=======================================
+ Hits         7419     7437   +18     
  Misses        260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Nov 15, 2024
@drewcorlin1 drewcorlin1 force-pushed the link-parameter-formatting branch from 4ba33d3 to 4e71fa4 Compare November 19, 2024 14:06
yurishkuro
yurishkuro previously approved these changes Nov 20, 2024
@yurishkuro yurishkuro changed the title Add ability to format link parameters #2487 Allow formatting link parameter values as ISO date #2487 Nov 20, 2024
@yurishkuro
Copy link
Member

please add this to the docs:

  • repo jaegertracing/documentation
  • files
    • content/docs/next-release-v2/frontend-ui.md
    • content/docs/next-release/frontend-ui.md

@drewcorlin1
Copy link
Contributor Author

Planning on updating those docs this week

@drewcorlin1
Copy link
Contributor Author

Doc updates are here jaegertracing/documentation#807

@yurishkuro yurishkuro merged commit d9315c6 into jaegertracing:main Nov 30, 2024
8 checks passed
yurishkuro pushed a commit to jaegertracing/documentation that referenced this pull request Dec 1, 2024
## Which problem is this PR solving?
Documentation associated with
jaegertracing/jaeger-ui#2501

Signed-off-by: Drew Corlin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Allow formatting template variables in link patterns

2 participants