-
Notifications
You must be signed in to change notification settings - Fork 585
Allow formatting link parameter values as ISO date #2487 #2501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yurishkuro
merged 2 commits into
jaegertracing:main
from
drewcorlin1:link-parameter-formatting
Nov 30, 2024
Merged
Allow formatting link parameter values as ISO date #2487 #2501
yurishkuro
merged 2 commits into
jaegertracing:main
from
drewcorlin1:link-parameter-formatting
Nov 30, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2aae90b to
4ba33d3
Compare
yurishkuro
reviewed
Nov 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2501 +/- ##
=======================================
Coverage 96.61% 96.62%
=======================================
Files 254 255 +1
Lines 7679 7697 +18
Branches 1931 2001 +70
=======================================
+ Hits 7419 7437 +18
Misses 260 260 ☔ View full report in Codecov by Sentry. |
4ba33d3 to
4e71fa4
Compare
yurishkuro
reviewed
Nov 20, 2024
yurishkuro
previously approved these changes
Nov 20, 2024
|
please add this to the docs:
|
|
Planning on updating those docs this week |
|
Doc updates are here jaegertracing/documentation#807 |
Signed-off-by: Drew Corlin <[email protected]>
a1fd97d to
f588298
Compare
yurishkuro
approved these changes
Nov 30, 2024
4 tasks
yurishkuro
pushed a commit
to jaegertracing/documentation
that referenced
this pull request
Dec 1, 2024
## Which problem is this PR solving? Documentation associated with jaegertracing/jaeger-ui#2501 Signed-off-by: Drew Corlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #2487
Description of the changes
Add the ability to format link variables.
How was this change tested?
Unit tests and by running it locally with the following UI config
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test