Update docs for link parameter formatting #807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for romantic-neumann-1959d7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
drewcorlin1
commented
Nov 30, 2024
4 tasks
yurishkuro
approved these changes
Nov 30, 2024
Member
|
please amend the commit with sing-off |
drewcorlin1
force-pushed
the
link-paramter-formatting
branch
2 times, most recently
from
44c2274 to
3a84cce
Compare
Closed
Member
|
Please check linters |
drewcorlin1
force-pushed
the
link-paramter-formatting
branch
from
3a84cce to
969453e
Compare
yurishkuro
reviewed
Dec 1, 2024
Member
yurishkuro
left a comment
yurishkuro
left a comment
There was a problem hiding this comment.
let's combine with add function in one change
drewcorlin1
force-pushed
the
link-paramter-formatting
branch
from
969453e to
3a5edbe
Compare
yurishkuro
reviewed
Dec 1, 2024
Signed-off-by: Drew Corlin <[email protected]>
drewcorlin1
force-pushed
the
link-paramter-formatting
branch
from
3a5edbe to
ec73975
Compare
Contributor
Author
|
thanks for all the reviews @yurishkuro ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Documentation associated with jaegertracing/jaeger-ui#2501