Make default gltf extensions registrable statically #2107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardobl
force-pushed
the
gltfstaticext
branch
from
dafd524 to
0527c97
Compare
Contributor
|
It appears that this change introduces a problem with multithreading that has been solved previously. |
Member
Author
This doesn't revert to the previous behavior, instead it registers statically only the classes on a concurrent hash map and then each instance of the loader creates a local instance of every extension. This makes it thread safe. |
Contributor
|
OK, thank you for clarifying my doubts. |
Member
|
Unless there's additional substantive discussion, I plan to integrate this PR in about 36 hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes default extensions registrable statically, to allows specific modules (think about (j)bullet, minie etc) to statically register their own extension in the gltf loader.
Similar to what is done in other contexts (eg. blender) that allow to extend their gltf importer/exporter.