Add userdata loader to gltf #2106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codex128
approved these changes
Nov 5, 2023
Contributor
codex128
left a comment
codex128
left a comment
There was a problem hiding this comment.
Just a couple small adjustments I think should be made if possible. Otherwise, I think these changes are fine.
jme3-plugins/src/gltf/java/com/jme3/scene/plugins/gltf/CustomContentManager.java
Outdated
Show resolved
Hide resolved
jme3-plugins/src/gltf/java/com/jme3/scene/plugins/gltf/GltfModelKey.java
Outdated
Show resolved
Hide resolved
riccardobl
force-pushed
the
gltfuserdata
branch
from
d1edf15 to
2fcd02a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a default user data loader from Simsilica's JmeConvert to the GLTF loader to make it load custom properties/extras as user data.