PreNormalPass fix for Unshaded and PBRLighting #1512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resync fork
Update fork
… in the atlases instead of setting a predefined byte buffer on disposal that made all atlases in the backend use the same buffer and generated rendering issues.
Fork update
…d more images to the screens so it really uses more atlases
Update fork PR
Update fork
Update fork
Member
|
Ready for review? |
joliver82
changed the title
Contributor
Author
|
Yes, now it's ready for review |
Member
|
Thanks, @joliver82 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transparent unshaded materials had an issue with SSAO (and potentially any other filter using the PreNormalPass). Fragments with alpha < alpha threshold were not discarded, so normals were rendered and used for SSAO calculations.
Details at hub post: https://hub.jmonkeyengine.org/t/fix-transparent-unshaded-materials-ssao/44482
EDIT: updated to fix PBRLighting also