Skip to content

Conversation

@MeFisto94
Copy link
Member

  • GLSLCompat now implements mat3(mat4) and determinant() and inverse() for mat2 and mat3
  • PBR.glslib uses this functions again instead of one-off workarounds

 - GLSLCompat now implements mat3(mat4) and determinant() and inverse() for mat2 and mat3
 - PBR.glslib uses this functions again instead of one-off workarounds
@pspeed42
Copy link
Contributor

pspeed42 commented Apr 4, 2020

Code looks good to me.

@MeFisto94
Copy link
Member Author

MeFisto94 commented Apr 4, 2020

https://github.com/MeFisto94/test-spotbugs/runs/560300340#step:5:1972 which refers to https://github.com/MeFisto94/test-spotbugs/runs/560300340#step:5:1280
Any idea? To me it reads like it didn't expect the function name, as in I cannot use mat3 as function return type? (Notice the column 6), but maybe it's some basic GLSL Syntax fault?

Edit: Confirmed with an online glsl editor: mat3 cannot be used as a function name (reserved keyword).

Follow up commit underway.

@MeFisto94
Copy link
Member Author

@MeFisto94 MeFisto94 merged commit 8f8fc19 into jMonkeyEngine:master Apr 4, 2020
@stephengold stephengold added this to the v3.3.1 milestone Apr 16, 2020
@stephengold
Copy link
Member

Included in v3.3 branch at f68d889.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants