test(e2e): deploy ERC20s with different decimals #1220
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
force-pushed
the
alexey/e2e-different-decimals
branch
from
9ec732c to
18a22d0
Compare
klkvr
force-pushed
the
alexey/e2e-different-decimals
branch
from
18a22d0 to
bbbbe50
Compare
shekhirin
commented
Sep 3, 2025
| // Either 6 or 18 decimals to test interop between same asset UIDs with different decimals. | ||
| // | ||
| // TODO: is there a nicer way to do this deterministically? | ||
| let decimals_ = if provider.get_chain_id().await? % 2 == 0 { 6 } else { 18 }; |
Contributor
Author
There was a problem hiding this comment.
I'd rather not tie this to chain ID, and instead maybe pass rng all the way to this function, so that we can set the seed if we want. Making it a derivative of chain ID means that all ERC-20 on that chain will have the same number of decimals, right?
Member
There was a problem hiding this comment.
yeah agree that this feels a bit hacky, though I wouldn't want it to be random either because with 4 retries any failing test will likely just be retried and succeed
another option would be to run all kinds of configurations like we do with payment configs
Lines 45 to 51 in f8d6585
Member
|
was merged into #1201 |
klkvr
added a commit
that referenced
this pull request
Sep 8, 2025
Fixes #1200 Blocked by #1220, needs testing --------- Co-authored-by: Arsenii Kulikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for #1200