feat(interop): account for different decimals across chains #1201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
force-pushed
the
alexey/interop-asset-decimals
branch
2 times, most recently
from
e85a0ac to
f346a27
Compare
klkvr
force-pushed
the
alexey/interop-asset-decimals
branch
from
fcf8a85 to
fae2d19
Compare
klkvr
force-pushed
the
alexey/interop-asset-decimals
branch
from
fae2d19 to
07aa730
Compare
shekhirin
commented
Sep 8, 2025
shekhirin
commented
Sep 8, 2025
Contributor
Author
shekhirin
left a comment
shekhirin
left a comment
There was a problem hiding this comment.
LGTM, can't approve my own PRs.
klkvr
approved these changes
Sep 8, 2025
Contributor
|
@shekhirin @klkvr whats up with the failing tests? |
Member
|
|
klkvr
added a commit
that referenced
this pull request
Sep 11, 2025
Right now `source_funds` might return `FundSource`s even if we don't have enough balance on source chain to pay the fees. This is being triggered by a bug in #1201 which sorted source chains by ascending balance order instead of descending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1200
Blocked by #1220, needs testing