Skip to content

Data merge concurrency #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coreyfarrell merged 4 commits into from
Apr 1, 2020
Merged

Data merge concurrency #1293

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5fa23a
chore: ignore JetBrains IDE files
canonic-epicure Mar 23, 2020
9c95e2d
fix: Merge reports with concurrency limit instead of fetching everyth…
canonic-epicure Mar 23, 2020
722a15a
chore: Revert "chore: ignore JetBrains IDE files"
canonic-epicure Mar 23, 2020
a33227f
chore: comment for `coverageData`
canonic-epicure Mar 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ test/build/
self-coverage/
*.swp
needs-transpile.js
/.idea
Comment thread
coreyfarrell marked this conversation as resolved.
Outdated
13 changes: 9 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,11 +408,16 @@ class NYC {

async getCoverageMapFromAllCoverageFiles (baseDirectory) {
const map = libCoverage.createCoverageMap({})
const files = await this.coverageFiles(baseDirectory)

const data = await this.coverageData(baseDirectory)
Comment thread
canonic-epicure marked this conversation as resolved.
data.forEach(report => {
map.merge(report)
})
await pMap(
files,
async f => {
const report = await this.coverageFileLoad(f, baseDirectory)
map.merge(report)
},
{ concurrency: os.cpus().length }
)

map.data = await this.sourceMaps.remapCoverage(map.data)

Expand Down