Data merge concurrency#1293
Merged
coreyfarrell merged 4 commits intoApr 1, 2020
Merged
Conversation
coreyfarrell
requested changes
Mar 23, 2020
Member
coreyfarrell
left a comment
coreyfarrell
left a comment
There was a problem hiding this comment.
This seems logical to me, I'd like to get some more feedback from reporters of the OOM issue to verify it actually fixes the issue before actually merging and releasing.
coreyfarrell
approved these changes
Apr 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1263
Instead of fetching all reports into memory and then merging, we do that one-by-one.