Skip to content

[Codegen] Implement ValueBoundsOpInterface and fully migrate vectorization for ToLayoutOp. #23766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanhanW merged 2 commits into from
Mar 13, 2026
Merged

[Codegen] Implement ValueBoundsOpInterface and fully migrate vectorization for ToLayoutOp. #23766

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec60229
[Codegen] Retire VectorizeIREEVectorExtOps pass.
hanhanW Mar 12, 2026
88328d7
Implemnet ValueBound interface for the op
hanhanW Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions compiler/src/iree/compiler/Codegen/Dialect/VectorExt/Transforms/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ iree_compiler_cc_library(
"LowerTransferGatherOps.cpp",
"Passes.cpp",
"VectorExtFoldUnitExtentDims.cpp",
"VectorizeIREEVectorExtOps.cpp",
],
hdrs = [
"BufferizationInterfaces.h",
Expand All @@ -52,7 +51,6 @@ iree_compiler_cc_library(
deps = [
":PassesIncGen",
"//compiler/src/iree/compiler/Codegen/Dialect/VectorExt/IR:IREEVectorExtDialect",
"//compiler/src/iree/compiler/Codegen/Interfaces:VectorizableOpInterface",
"@llvm-project//llvm:Support",
"@llvm-project//mlir:ArithDialect",
"@llvm-project//mlir:BufferizationDialect",
Expand Down
2 changes: 0 additions & 2 deletions compiler/src/iree/compiler/Codegen/Dialect/VectorExt/Transforms/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ iree_cc_library(
"LowerTransferGatherOps.cpp"
"Passes.cpp"
"VectorExtFoldUnitExtentDims.cpp"
"VectorizeIREEVectorExtOps.cpp"
DEPS
::PassesIncGen
LLVMSupport
Expand All @@ -52,7 +51,6 @@ iree_cc_library(
MLIRVectorDialect
MLIRVectorUtils
iree::compiler::Codegen::Dialect::VectorExt::IR::IREEVectorExtDialect
iree::compiler::Codegen::Interfaces::VectorizableOpInterface
PUBLIC
)

Expand Down
8 changes: 0 additions & 8 deletions compiler/src/iree/compiler/Codegen/Dialect/VectorExt/Transforms/Passes.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,6 @@

include "mlir/Pass/PassBase.td"

def VectorizeIREEVectorExtOpsPass :
Pass<"iree-vector-ext-vectorize-ops", ""> {
let summary = "Vectorizes then lowers a few iree_vector_ext ops before vectorization.";
let dependentDialects = [
"::mlir::iree_compiler::IREE::VectorExt::IREEVectorExtDialect"
];
}

def VectorExtFoldUnitExtentDimsPass :
Pass<"iree-vector-ext-fold-unit-extent-dims", ""> {
let summary = "Folds unit dims for iree_vector_ext ops";
Expand Down
56 changes: 0 additions & 56 deletions ...iler/src/iree/compiler/Codegen/Dialect/VectorExt/Transforms/VectorizeIREEVectorExtOps.cpp
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion ...src/iree/compiler/Codegen/Dialect/VectorExt/Transforms/test/vectorize_vector_ext_ops.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// RUN: iree-opt %s -pass-pipeline='builtin.module(func.func(iree-vector-ext-vectorize-ops, iree-codegen-generic-vectorization{enable-vector-masking=true}),canonicalize,cse,func.func(iree-codegen-optimize-tensor-insert-extract-slices),canonicalize)' --split-input-file --mlir-print-local-scope | FileCheck %s
// RUN: iree-opt %s -pass-pipeline='builtin.module(func.func(iree-codegen-generic-vectorization{enable-vector-masking=true}),canonicalize,cse,func.func(iree-codegen-optimize-tensor-insert-extract-slices),canonicalize)' --split-input-file --mlir-print-local-scope | FileCheck %s

#layout = #iree_vector_ext.nested_layout<
subgroup_tile = [1, 1],
Expand Down
3 changes: 0 additions & 3 deletions compiler/src/iree/compiler/Codegen/LLVMGPU/Passes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
#include "iree/compiler/Codegen/Common/Passes.h"
#include "iree/compiler/Codegen/Dialect/Codegen/IR/IREECodegenOps.h"
#include "iree/compiler/Codegen/Dialect/GPU/Transforms/Passes.h"
#include "iree/compiler/Codegen/Dialect/VectorExt/Transforms/Passes.h"
#include "iree/compiler/Codegen/LLVMGPU/Passes.h"
#include "iree/compiler/Codegen/LLVMGPU/ROCDLPasses.h"
#include "iree/compiler/Codegen/Utils/GPUUtils.h"
Expand Down Expand Up @@ -274,8 +273,6 @@ static void addGPUVectorizationPasses(OpPassManager &funcPassManager,
funcPassManager.addPass(IREE::LinalgExt::createDecomposeIm2colPass());
funcPassManager.addPass(createCanonicalizerPass());
funcPassManager.addPass(createCSEPass());
funcPassManager.addPass(
IREE::VectorExt::createVectorizeIREEVectorExtOpsPass());
funcPassManager.addPass(IREE::GPU::createVectorizeIREEGPUOpsPass());
// Vectorize.
GenericVectorizationPassOptions options;
Expand Down
Loading