[Codegen] Implement ValueBoundsOpInterface and fully migrate vectorization for ToLayoutOp.#23766
Merged
[Codegen] Implement ValueBoundsOpInterface and fully migrate vectorization for ToLayoutOp.#23766
Conversation
The VectorExt ops implement vectorization through VectorizableOpInterface, and it is fully migrated to GenericVectorization.cpp. Thus, the pass can be retired. Signed-off-by: hanhanW <hanhan0912@gmail.com>
hanhanW
requested review from
Groverkss,
Max191,
krzysz00,
kuhar,
nirvedhmeshram and
qedawkins
as code owners
hanhanW
requested review from
sommerlukas
and removed request for
krzysz00,
kuhar and
qedawkins
kuhar
approved these changes
Mar 12, 2026
sommerlukas
approved these changes
Mar 13, 2026
Member
|
@hanhanW seems like there are some actual regressions? |
Contributor
Author
yeah, I can reproduce it on my workstation, looking |
hanhanW
changed the title
Signed-off-by: hanhanW <hanhan0912@gmail.com>
hanhanW
force-pushed
the
users/hanhanW/vec-iface-c4
branch
from
e1299a4 to
88328d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VectorExt ops implement vectorization through VectorizableOpInterface, and it is fully migrated to GenericVectorization.cpp. Thus, the VectorizeIREEVectorExtOps pass can be retired.