Skip to content

feat(facets): register overriden range facet element as default #3305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zubeydecivelek wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(facets): register overriden range facet element as default #3305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/collectionRecordsSearch/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
ContribSearchAppFacets,
ContribBucketAggregationElement,
ContribBucketAggregationValuesElement,
ContribRangeFacetElement,
} from "@js/invenio_search_ui/components";

const appName = "InvenioAppRDM.CollectionsSearch";
Expand All @@ -40,6 +41,7 @@ const CommunityRecordSearchAppLayoutWAppName = parametrize(
const defaultComponents = {
[`${appName}.BucketAggregation.element`]: ContribBucketAggregationElement,
[`${appName}.BucketAggregationValues.element`]: ContribBucketAggregationValuesElement,
[`${appName}.RangeFacet.element`]: ContribRangeFacetElement,
[`${appName}.ResultsGrid.item`]: RDMRecordResultsGridItem,
[`${appName}.EmptyResults.element`]: RDMEmptyResults,
[`${appName}.ResultsList.item`]: RecordsResultsListItem,
Expand Down
2 changes: 2 additions & 0 deletions invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/communityRecordsSearch/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import {
ContribSearchAppFacets,
ContribBucketAggregationElement,
ContribBucketAggregationValuesElement,
ContribRangeFacetElement,
} from "@js/invenio_search_ui/components";

const appName = "InvenioCommunities.DetailsSearch";
Expand All @@ -45,6 +46,7 @@ const CommunityRecordsResultsListItem = parametrize(RecordsResultsListItem, {
const defaultComponents = {
[`${appName}.BucketAggregation.element`]: ContribBucketAggregationElement,
[`${appName}.BucketAggregationValues.element`]: ContribBucketAggregationValuesElement,
[`${appName}.RangeFacet.element`]: ContribRangeFacetElement,
[`${appName}.ResultsGrid.item`]: RDMRecordResultsGridItem,
[`${appName}.EmptyResults.element`]: RDMEmptyResults,
[`${appName}.ResultsList.item`]: CommunityRecordsResultsListItem,
Expand Down
2 changes: 2 additions & 0 deletions invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/search/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
ContribSearchAppFacets,
ContribBucketAggregationElement,
ContribBucketAggregationValuesElement,
ContribRangeFacetElement,
} from "@js/invenio_search_ui/components";

const ContribSearchAppFacetsWithConfig = parametrize(ContribSearchAppFacets, {
Expand All @@ -44,6 +45,7 @@ const RDMRecordResultsListItemWithConfig = parametrize(
export const defaultComponents = {
[`${appName}.BucketAggregation.element`]: ContribBucketAggregationElement,
[`${appName}.BucketAggregationValues.element`]: ContribBucketAggregationValuesElement,
[`${appName}.RangeFacet.element`]: ContribRangeFacetElement,
[`${appName}.ResultsGrid.item`]: RDMRecordResultsGridItem,
[`${appName}.EmptyResults.element`]: RDMEmptyResults,
[`${appName}.ResultsList.item`]: RDMRecordResultsListItemWithConfig,
Expand Down
2 changes: 2 additions & 0 deletions invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/user_dashboard/communities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
ContribSearchAppFacets,
ContribBucketAggregationElement,
ContribBucketAggregationValuesElement,
ContribRangeFacetElement,
} from "@js/invenio_search_ui/components";
import { overrideStore, parametrize } from "react-overridable";

Expand All @@ -38,6 +39,7 @@ const DashboardResultViewWAppName = parametrize(DashboardResultView, {
export const defaultComponents = {
[`${appName}.BucketAggregation.element`]: ContribBucketAggregationElement,
[`${appName}.BucketAggregationValues.element`]: ContribBucketAggregationValuesElement,
[`${appName}.RangeFacet.element`]: ContribRangeFacetElement,
[`${appName}.EmptyResults.element`]: CommunitiesEmptySearchResults,
[`${appName}.SearchApp.facets`]: ContribSearchAppFacets,
[`${appName}.ResultsList.item`]: CommunityItem,
Expand Down
2 changes: 2 additions & 0 deletions invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/user_dashboard/requests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {
ContribBucketAggregationElement,
ContribBucketAggregationValuesElement,
ContribSearchAppFacets,
ContribRangeFacetElement,
} from "@js/invenio_search_ui/components";
import PropTypes from "prop-types";
import React from "react";
Expand Down Expand Up @@ -58,6 +59,7 @@ const RequestsSearchLayoutWithApp = parametrize(RequestsSearchLayout, {
export const defaultComponents = {
[`${appName}.BucketAggregation.element`]: ContribBucketAggregationElement,
[`${appName}.BucketAggregationValues.element`]: ContribBucketAggregationValuesElement,
[`${appName}.RangeFacet.element`]: ContribRangeFacetElement,
Copy link
Member

@palkerecsenyi palkerecsenyi Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this override even on pages where we aren't using the date facet? I guess it doesn't hurt but it would maybe be confusing for future developers if it isn't actually used.

[`${appName}.SearchApp.facets`]: ContribSearchAppFacets,
[`${appName}.ResultsList.item`]: RequestsResultsItemTemplateDashboard,
[`${appName}.ResultsGrid.item`]: () => null,
Expand Down
2 changes: 2 additions & 0 deletions invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/user_dashboard/uploads.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import {
ContribSearchAppFacets,
ContribBucketAggregationElement,
ContribBucketAggregationValuesElement,
ContribRangeFacetElement,
} from "@js/invenio_search_ui/components";

const statuses = {
Expand Down Expand Up @@ -190,6 +191,7 @@ const DashboardResultViewWAppName = parametrize(DashboardResultView, {
export const defaultComponents = {
[`${appName}.BucketAggregation.element`]: ContribBucketAggregationElement,
[`${appName}.BucketAggregationValues.element`]: ContribBucketAggregationValuesElement,
[`${appName}.RangeFacet.element`]: ContribRangeFacetElement,
[`${appName}.Count.element`]: RDMCountComponent,
[`${appName}.EmptyResults.element`]: RDMEmptyResults,
[`${appName}.ResultsList.item`]: RDMRecordResultsListItem,
Expand Down
Loading