Skip to content

feat(facets): register overriden range facet element as default#3305

Open
zubeydecivelek wants to merge 1 commit intoinveniosoftware:masterfrom
zubeydecivelek:date-facet-override
Open

feat(facets): register overriden range facet element as default#3305
zubeydecivelek wants to merge 1 commit intoinveniosoftware:masterfrom
zubeydecivelek:date-facet-override

Conversation

@zubeydecivelek
Copy link
Contributor

@zubeydecivelek zubeydecivelek commented Jan 28, 2026

closes CERNDocumentServer/cds-rdm#209
needs inveniosoftware/invenio-search-ui#245

❤️ Thank you for your contribution!

Description

Registered the overriden ContribRangeFacetElement in invenio-search-ui. See here

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

export const defaultComponents = {
[`${appName}.BucketAggregation.element`]: ContribBucketAggregationElement,
[`${appName}.BucketAggregationValues.element`]: ContribBucketAggregationValuesElement,
[`${appName}.RangeFacet.element`]: ContribRangeFacetElement,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this override even on pages where we aren't using the date facet? I guess it doesn't hurt but it would maybe be confusing for future developers if it isn't actually used.

@palkerecsenyi
Copy link
Member

We need to update the luxon version too, as this is causing a conflict with the version in react-invenio-forms:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Group records by year

3 participants