feat(facets): register overriden range facet element as default#3305
Open
zubeydecivelek wants to merge 1 commit intoinveniosoftware:masterfrom
Open
feat(facets): register overriden range facet element as default#3305zubeydecivelek wants to merge 1 commit intoinveniosoftware:masterfrom
zubeydecivelek wants to merge 1 commit intoinveniosoftware:masterfrom
Conversation
06bd4fd to
7f842de
Compare
| export const defaultComponents = { | ||
| [`${appName}.BucketAggregation.element`]: ContribBucketAggregationElement, | ||
| [`${appName}.BucketAggregationValues.element`]: ContribBucketAggregationValuesElement, | ||
| [`${appName}.RangeFacet.element`]: ContribRangeFacetElement, |
Member
There was a problem hiding this comment.
Do we need this override even on pages where we aren't using the date facet? I guess it doesn't hurt but it would maybe be confusing for future developers if it isn't actually used.
10 tasks
JakobMiesner
approved these changes
Feb 5, 2026
Member
|
We need to update the luxon version too, as this is causing a conflict with the version in react-invenio-forms: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes CERNDocumentServer/cds-rdm#209
needs inveniosoftware/invenio-search-ui#245
❤️ Thank you for your contribution!
Description
Registered the overriden
ContribRangeFacetElementininvenio-search-ui. See hereChecklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: